Closed
Bug 1537754
Opened 5 years ago
Closed 5 years ago
The same doorhanger animation as the one from LTR builds is displayed on the RTL Firefox builds
Categories
(Firefox :: Messaging System, defect, P1)
Firefox
Messaging System
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox66 | --- | unaffected |
firefox67 | --- | unaffected |
firefox68 | --- | verified |
People
(Reporter: mcoman, Assigned: rrosario)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
[Affected versions]:
- Firefox Nightly 68.0a1, Build ID 20190319215514
[Affected Platforms]:
- All Windows
- All Linux
- All Mac
[Prerequisites]:
- Have an RTL Firefox build installed (e.g. AR locale).
- Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref set to "true" in the "about:config" page.
[Steps to reproduce]:
- Open the browser with the profile from prerequisites.
- Navigate to the "about:newtab#asrouter" page and scroll down to the "PIN_TAB" section.
- Click the "Show" button and click the "CFR Recommendation" button from the left part of the "Address Bar".
- Observe the displayed animation.
[Expected result]:
- The doorhanger animation shows the RTL behavior.
[Actual result]:
- The same animation as the one from LTR builds is displayed.
[Notes]:
- Attached a screen recording of the issue.
Comment 1•5 years ago
|
||
Might be related to bug 1536483 ? unless that's more general than pin tabs ?
See Also: → 1536483
Comment 2•5 years ago
|
||
Amy, can you take a look at an RTL version of the animation? Thanks!
Flags: needinfo?(amlee)
Comment 3•5 years ago
|
||
Hi,
I've attached RTL assets. Let me know if you need anything else.
Flags: needinfo?(amlee)
Updated•5 years ago
|
Iteration: --- → 68.3 - Apr 15 - 28
Priority: -- → P1
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → rrosario
Assignee | ||
Comment 4•5 years ago
|
||
I shared some screengrabs with :amylee and we decided that we can just flip the existing images and animations with CSS and avoid adding more images. woot
Assignee | ||
Updated•5 years ago
|
Iteration: 68.3 - Apr 15 - 28 → 68.2 - Apr 1 - 14
Assignee | ||
Comment 5•5 years ago
|
||
MozReview-Commit-ID: 9uvCbIpQ4fa
Assignee | ||
Updated•5 years ago
|
Blocks: pinned-tabs-68
Pushed by rrosario@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb98b130573d The same doorhanger animation as the one from LTR builds is displayed on the RTL Firefox builds r=andreio
Comment 7•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Comment 8•5 years ago
|
||
Fix verified with 68.0b5 on Windows 10, macOS 10.13, Ubuntu 16.04 using the he_language build.
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•