The same doorhanger animation as the one from LTR builds is displayed on the RTL Firefox builds

VERIFIED FIXED in Firefox 68

Status

()

defect
P1
normal
VERIFIED FIXED
5 months ago
2 months ago

People

(Reporter: mcoman, Assigned: rrosario)

Tracking

(Blocks 1 bug)

Trunk
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox66 unaffected, firefox67 unaffected, firefox68 verified)

Details

Attachments

(3 attachments)

Posted image rec of the issue.gif

[Affected versions]:

  • Firefox Nightly 68.0a1, Build ID 20190319215514

[Affected Platforms]:

  • All Windows
  • All Linux
  • All Mac

[Prerequisites]:

  • Have an RTL Firefox build installed (e.g. AR locale).
  • Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref set to "true" in the "about:config" page.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Navigate to the "about:newtab#asrouter" page and scroll down to the "PIN_TAB" section.
  3. Click the "Show" button and click the "CFR Recommendation" button from the left part of the "Address Bar".
  4. Observe the displayed animation.

[Expected result]:

  • The doorhanger animation shows the RTL behavior.

[Actual result]:

  • The same animation as the one from LTR builds is displayed.

[Notes]:

  • Attached a screen recording of the issue.
Blocks: 1536846

Might be related to bug 1536483 ? unless that's more general than pin tabs ?

See Also: → 1536483
Keywords: uiwanted

Amy, can you take a look at an RTL version of the animation? Thanks!

Flags: needinfo?(amlee)

Hi,

I've attached RTL assets. Let me know if you need anything else.

Flags: needinfo?(amlee)
Iteration: --- → 68.3 - Apr 15 - 28
Priority: -- → P1
Assignee: nobody → rrosario

I shared some screengrabs with :amylee and we decided that we can just flip the existing images and animations with CSS and avoid adding more images. woot

Iteration: 68.3 - Apr 15 - 28 → 68.2 - Apr 1 - 14
Keywords: uiwanted
Pushed by rrosario@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb98b130573d
The same doorhanger animation as the one from LTR builds is displayed on the RTL Firefox builds r=andreio
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Fix verified with 68.0b5 on Windows 10, macOS 10.13, Ubuntu 16.04 using the he_language build.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.