1537757 - Breakpoint line marker is misaligned

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

STR:

1. Get the attached React App
2. Run yarn install && yarn start
3. Load localhost:3000
4. Open src/App.js
5. Create BP on line 7 console.trace("render");
6. Right click on that line and jump to generated location
7. Remove the breakpoint in generated file, right click and jump to original location
8. The breakpoint marker in the BP gutter is misaligned -> BUG

The breakpoint shouldn't be there at all

See also the attached screenshot

Note that I had to close all source tabs in the Debugger panel and restart the Browser to be able to repro this again.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: app.rar

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Another thing here: when jumping to generated location, line under the console.trace("render"); is highighted. Directly the line console.trace("render"); should be highlighted. Let me know if you want me to file another bug for this.

Honza

Comment 3

[Jason Laster [:jlast]]

I'm not sure how to download and open app.rar? Would it be possible to host the app with glitch or https://codesandbox.io/?

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: app.zip

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Changed to zip

Honza

Comment 6

[Jason Laster [:jlast]]

Here is a similar example --

1. go to https://8k0y15nvj8.codesandbox.io/
2. add a breakpoint in https://p798ppq8mj.codesandbox.io/src/index.js (mapped)
3. switch to the generated location
4. remove the breakpoint
5. switch to the original location

http://g.recordit.co/mFUeVLAEkg.gif

Comment 7

[David Walsh :davidwalsh]

I was able to reproduce. Switching tabs doesn't fix the issue, though if you click the line gutter again, the breakpoint is put back in the correct place.

Comment 8

[David Walsh :davidwalsh]

Looks like componentWillUnmount from Breakpoint.js isn't running when swapping back to the original location, thus the new-breakpoint class isn't removed from the document.

Comment 9

[Jason Laster [:jlast]]

Attachment: Bug 1537757 - Breakpoint line marker is misaligned. r=dwalsh

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03035705f087
Breakpoint line marker is misaligned. r=davidwalsh

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/03035705f087