Figure out correct width of border between tabs and nav bar at 300% DPI

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: dao, Assigned: dao)

Tracking

unspecified
Firefox 68
Desktop
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Assignee

Description

3 months ago

From https://phabricator.services.mozilla.com/D24173#inline-141249:

On Windows you can go up to at least 3dppx - should we add another one for that case?

Windows doesn't offer 300% with my current hardware so I'm unable to check what the native behavior is. Is there a trick to enabling this? Otherwise, Gijs, can you check?

Flags: needinfo?(gijskruitbosch+bugs)

Comment 1

3 months ago

(In reply to Dão Gottwald [::dao] from comment #0)

From https://phabricator.services.mozilla.com/D24173#inline-141249:

On Windows you can go up to at least 3dppx - should we add another one for that case?

Windows doesn't offer 300% with my current hardware so I'm unable to check what the native behavior is. Is there a trick to enabling this?

I'm not aware of it if there is; Google offers this suggestion . Does that help?

Otherwise, Gijs, can you check?

I just recalled that my surface pro offered very high values at one point; it's possible that this has gone away again with newer insider builds. It looks like right now it maxes out at 225%.

But also, even if I had the hardware, I'm not sure what specifically you mean by "the native behavior". What would one be looking for? (If the above workaround doesn't help, perhaps we can ask QE?)

Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(dao+bmo)

Comment 2

3 months ago

Looks like my main machine offers 300% and 350%, so I can check what you're interested in once I know what it is. :-)

Assignee

Comment 3

3 months ago

(In reply to :Gijs (he/him) from comment #1)

But also, even if I had the hardware, I'm not sure what specifically you mean by "the native behavior". What would one be looking for?

I'm looking for the size of the gap below the close button when hovered.

Flags: needinfo?(dao+bmo) → needinfo?(gijskruitbosch+bugs)

Comment 4

3 months ago
Posted image Nightly-300dpi-restored.png (obsolete) —
Flags: needinfo?(gijskruitbosch+bugs)

Comment 5

3 months ago

(In reply to Dão Gottwald [::dao] from comment #3)

Created attachment 9052599 [details]
screenshot of Explorer, 150% scaling

(In reply to :Gijs (he/him) from comment #1)

But also, even if I had the hardware, I'm not sure what specifically you mean by "the native behavior". What would one be looking for?

I'm looking for the size of the gap below the close button when hovered.

Oh, gah, the new bmo thing for attachments makes them easy to overlook. I guess you meant for explorer...

Comment 6

3 months ago
Posted image explorer-300-dpi.png

Looks like 1 device pixel as well, I think?

Attachment #9053231 - Attachment is obsolete: true
Assignee

Updated

3 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

Comment 8

3 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/387e71baf2ef
Adjust --tabs-navbar-shadow-size for 300% DPI. r=Gijs

Comment 9

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.