Closed Bug 1537770 Opened 6 months ago Closed 6 months ago

Ensure printing stacks when an exception happens in JSONHandler

Categories

(Remote Protocol :: Agent, enhancement, P1)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ato)

References

Details

Attachments

(1 file)

One patch of bug 1533679 allowed to prints the exception when one happens within a JSONHandler, but the stack were missing.
We should also ensure printing the stacks as that makes it really hard to track down the errors.

I am of reasonable sound mind and capable of fixing this.

Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1

When remote/JSONHandler.jsm intercepts errors thrown during the
handling of an HTTP request, it is without except the underlying
cause of the problem you wish RemoteAgentError#notify() to give you.

Under no circumstances are you interested in where the error is re-thrown.

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1ee8401a2c7
remote: default RemoteAgentError#notify() to print stack; r=ochameau
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.