1537776 - Enable ESLint rule no-throw-literal in dom/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Ian Moody [:Kwan] (UTC+0)]

no-throw-literal helps ensure that when we do throw errors, they come with stack traces that help track down the source of the error.

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1537776 - dom/ automated ESLint no-throw-literal fixes. r=asuth!,handyman!,mccr8!

Result of running:
$ mach eslint -funix dom/ | sed -Ee 's/:.+//' - | xargs sed -E
-e 's/throw ((["])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["])[^"]+\2 + [^ ";]+);/throw new Error(\1);/g'
-e 's/throw (/throw new Error(/g' -i

Comment 2

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1537776 - dom/ manual ESLint no-throw-literal fixes. r=mccr8

Comment 3

[Ian Moody [:Kwan] (UTC+0)]

Green try with one intermittent:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=24bc50f11129ce3ecaee238f9fdc8c27fe5e7997

Sheriffs, this is for both this and bug 1536659.
If any later child revisions from other bugs show up in the stack by the time you get to this you don't need to worry about them, only push up to here
https://lando.services.mozilla.com/D24370/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/842871b6e080
dom/ automated ESLint no-throw-literal fixes. r=asuth,mccr8

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55be3316a5cb
dom/ manual ESLint no-throw-literal fixes. r=asuth

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/842871b6e080
https://hg.mozilla.org/mozilla-central/rev/55be3316a5cb