1537885 - Unable to copy text from any webpage to clipboard

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Andrei Jolțan [:Andi]]

Environment:
Device Huawei MediaPad M3 Lite 10 (Android 7.0);
Build: Nightly - 68.0a1;

Steps to reproduce:

1. Select any word from a webpage and long tap on it.
2. Tap on the copy button from the toolbar
3. Try to paste the selected word

Expected result:
The selected text should be copied and the toolbar should disappear.

Actual result:
After tapping the Copy button the toolbar doesn't disappear and the text is not copied.

Notes:
The webpage links are successfully copied/pasted.
For more details please see the attachments:
Video
Logcat

Comment 1

[Andrei Bodea[:andrei]]

Hi, after checking with Petru it seems that your 2nd patch for the bug 676268 caused this regression Makoto.
Can you please check this?

Comment 2

[Petru-Mugurel Lingurar [:petru]]

[JavaScript Error: "TypeError: ActionBarHandler._getEditor(...) is null" {file: "resource://gre/modules/ActionBarHandler.jsm" line: 476}]

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1537885 - Use cmd_copy for copy command

Although I change to use editor by previous fix of bug 676268, it is not
good for non-editable content. cmd_copy can support editable and non-editable.

GV already uses cmd_copy for this.

Comment 5

[azizLIGHT]

This is happening to me on Firefox Nightly 68.0a1 on Android 6.0.1 (Samsung Galaxy S7 Edge)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca3e3ce4ec78
Use cmd_copy for copy command r=geckoview-reviewers,snorp

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/ca3e3ce4ec78

Comment 9

[Laurentiu Apahidean]

Hello,

I tested this issue on the latest version of Nightly 68.0a1 (2019-03-28) with Samsung Galaxy S8+ (Android 8.0.0) and Google Nexus 9 (Android 7.1.1) and I wasn't able to reproduce the issue.

Due to my findings, I'll mark this issue as verified.