1537936 - Remove pn_op from ParseNode

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Ashley Hauck [:khyperia]]

We're surprisingly close to getting this to happen.

I'll split the patch into three parts:

1. Misc. cleanup (some NameNode changes, tiny change to True/False/Undefined/NullExpr, etc.)
2. Function call cleanup.
3. Deleting pn_op and refactoring all the ParseNode constructors/FullParseHandler/etc. to not provide opcodes.

Point 2 is a little weird, because I'll be adding a CallNode that contains a JSOp field. This is because there are a lot of different types of calls, and those are currently encoded into JSOp (for example, CALL, SPREADCALL, NEW, SPREADNEW, SUPERCALL, SPREADSUPERCALL, the list goes on and on). I could make a new enum that corresponds basically 1-to-1 with the JSOp items, and make a mapping function, but... really, what's the point at that point.

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Bug 1537936 part 1 - Remove miscellaneous uses of pn_op.

Comment 2

[Ashley Hauck [:khyperia]]

Attachment: Bug 1537936 part 2 - Move pn_op for calls to CallNode::callOp.

Depends on D24409

Comment 3

[Ashley Hauck [:khyperia]]

Attachment: Bug 1537936 part 3 - Remove ParseNode::pn_op.

Depends on D24410

Comment 4

[Oana Pop-Rus]

Backed out for bustages in ParseNode.h

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=8c405aa4467dfeb34b9df7e875c1584ed6f6a938

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235272394&repo=autoland&lineNumber=5157

Backout: https://hg.mozilla.org/integration/autoland/rev/c99b0f4470527c183d90c1e7191a08e4933ad1ac

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/647eb65d3451
part 1 - Remove miscellaneous uses of pn_op. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/37d0dcbdffd5
part 2 - Move pn_op for calls to CallNode::callOp. r=jorendorff

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bf248bc4f3b
part 1 - Remove miscellaneous uses of pn_op. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/4011496a13a9
part 2 - Move pn_op for calls to CallNode::callOp. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/d9660cff2091
part 3 - Remove ParseNode::pn_op. r=jorendorff

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2bf248bc4f3b
https://hg.mozilla.org/mozilla-central/rev/4011496a13a9
https://hg.mozilla.org/mozilla-central/rev/d9660cff2091