1537967 - Consider not running the refresh driver in VR mode, or at least skipping the painting machinery

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Markus Stange [:mstange]]

In this profile of running a VR scene in the FxR browser, nsRefreshDriver::Tick takes up 2.6% of the total time: https://perfht.ml/2YjS5kC

Can we skip this work, or throttle it really aggressively? As far as I know, in VR mode, what the refresh driver paints will not end up on the screen until you leave VR mode.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1537967 - Skipping running refresh driver and compositing in VR mode.

MozReview-Commit-ID: 4L3PygFSFCB

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/553d7f3d8eed
Skipping running refresh driver and compositing in VR mode. r=mstange,kip

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 553d7f3d8eed (bug 1537967) for Marionette failures in testing/firefox-ui/tests/functional/security/test_mixed_content_page.py

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239554504&repo=autoland&lineNumber=5827

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=553d7f3d8eed1ab15fbf5f4b30dc861284bbb927

Backout:
https://hg.mozilla.org/integration/autoland/rev/4d47e0abfaa821d2e49ec1a2e6828ebdde810ceb

Comment 4

[Daosheng Mu[:daoshengmu]]

Try looks good now, https://treeherder.mozilla.org/#/jobs?repo=try&revision=54c150fb148f32969d74d99ed4c195f719190699

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84e57dd0aa71
Skipping running refresh driver and compositing in VR mode. r=mstange,kip

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/84e57dd0aa71

Comment 7

[Randall Barker [:rbarker]]

This patch caused a regression in Firefox Reality. Since it short circuits the refresh driver, WillRefresh() calls are not make and this breaks the MediaRecorder.

Comment 8

[Daosheng Mu[:daoshengmu]]

(In reply to Randall Barker [:rbarker] from comment #7)

This patch caused a regression in Firefox Reality. Since it short circuits the refresh driver, WillRefresh() calls are not make and this breaks the MediaRecorder.

I supposed when doing VR immersive mode, we don't need Compositor to handle painting, I was thinking the immersive frames usually come from WebGL texture, and they don't need be through the compositor.

If there are a lot of cases still need compositor painting in the immersive mode, we should consider to undo this change.

Comment 9

[Randall Barker [:rbarker]]

This was fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1575694