Associate GeckoSession EventDispatcher with the correct window

RESOLVED FIXED in Firefox 67

Status

()

defect
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
mozilla68
All
Android
Points:
---

Firefox Tracking Flags

(firefox66 wontfix, firefox67 fixed, firefox68 fixed)

Details

(Whiteboard: [geckoview:fenix:p2] )

Attachments

(1 attachment)

For some reason, GeckoView in Fenix creates a dummy window and AccessFu erroneously tries to pass messages to it because it is what it gets from Services.wm.getMostRecentWindow().

Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4e3f008e541
Use owner of WindowEventDispatcher as window for messaging. r=yzen
Whiteboard: [geckoview:fenix:p2]
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Eitan, do we need to uplift this fix to 67 Beta for Fenix MVP?

Flags: needinfo?(eitan)

(In reply to Chris Peterson [:cpeterson] from comment #4)

Eitan, do we need to uplift this fix to 67 Beta for Fenix MVP?

Yes

Flags: needinfo?(eitan)

Comment on attachment 9052738 [details]
Bug 1538021 - Use owner of WindowEventDispatcher as window for messaging. r?yzen!

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: TalkBack users will not be able to access web content until they put two fingers on the screen
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): We have good test coverage here, and this should be more robust than what we had
  • String changes made/needed:
Attachment #9052738 - Flags: approval-mozilla-beta?

Comment on attachment 9052738 [details]
Bug 1538021 - Use owner of WindowEventDispatcher as window for messaging. r?yzen!

a11y fix for Talkback users with tests and on Nightly for 6 days, uplift approved for 67 beta 7, thanks.

Attachment #9052738 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.