Closed Bug 1538113 Opened 8 months ago Closed 8 months ago

Fix warnings from bug 1423253 landing

Categories

(Core :: Audio/Video: Recording, enhancement, P3)

65 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(4 files)

Reviewbot decided to pass up a whole bunch of other warnings now, after the queuing to autoland, so let's just fix them all here.

Depends on: 1423253
Summary: Warning: 'segment' used after it was moved [clang-tidy: bugprone-use-after-move] in TestVideoTrackEncoder.cpp → Fix warnings from bug 1423253 landing

Sooo, not all can be fixed. Statuses inline:

(In reply to Andreas Pehrson [:pehrsons] from comment #2)

The ones in question are, for now, in order:

https://phabricator.services.mozilla.com/D22906#inline-142034

This uninitialized mCurrentTime changed type in a later patch and now has a default constructor.

https://phabricator.services.mozilla.com/D22909#inline-140683

Done

https://phabricator.services.mozilla.com/D22910#inline-142013

Done, together with all of dom/media/webrtc

https://phabricator.services.mozilla.com/D22914#717571

Done

https://phabricator.services.mozilla.com/D24233#inline-142010
https://phabricator.services.mozilla.com/D24233#inline-142011

Done

https://phabricator.services.mozilla.com/D24234#717483

Done

Initially indicated by https://phabricator.services.mozilla.com/D22909#inline-140683
Some more found by ./mach static-analysis check dom/media/gtest/TestVideoTrackEncoder.cpp

Initially indicated by: https://phabricator.services.mozilla.com/D22910#inline-142013
Rest found by: ./mach static-analysis check dom/media/webrtc

This removes windows line endings throughout the files, and clang-formats them.

Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/946a9c169fb4
Fix TestVideoTrackEncoder static-analysis warnings. r=bryce
https://hg.mozilla.org/integration/autoland/rev/d56e561be43f
Fix dom/media/webrtc static-analysis warnings. r=jib
https://hg.mozilla.org/integration/autoland/rev/ad6e8a453d67
Fix static-analysis warning in dom/media/VideoFrameConverter.h. r=dminor
https://hg.mozilla.org/integration/autoland/rev/b1d3a147fdc9
Format YUVBufferGenerator. r=dminor
You need to log in before you can comment on or make changes to this bug.