1538134 - Leave PGO decision to mozconfigs and taskcluster, not mozharness

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

See discussion in bug 1534272.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1538134: [mozharness] Set repository path in taskcluster; r?aki

Taskcluster has authorative information about the repository being built, so
pass that to mozharness, rather than have mozharness reconstruct it from
hand-maintained mozharness config.

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1538134: [mozharness] Remove explicit setting of branches to use release promotion; r?aki

The only thing this affects is the default update channel, but for shipping builds, this is set
explicitly via taskcluster, and for other branches, defaults to default.

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1538134: [mozharness] Don't override PGO settings per-branch; r?aki

The release mozconfigs set MOZ_PGO and all shipping builds set the nightly
mozharness config, so we don't need to additionaly set PGO based on the branch.

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1538134: [mozharness] Remove support for unused `builds/branch_specifics.py` config; r?aki

We have moved per-branch configuration to taskcluster, so we can remove that
support in mozharness.

Comment 5

[Andreea Pavel [:apavel]]

Can this be landed?

Comment 6

[Tom Prince [:tomprince]]

(In reply to Andreea Pavel [:apavel] from comment #5)

Can this be landed?

Not yet. I still need to do some testing on this.

Comment 7

[Mike Hommey [:glandium]]

If you're asking for bug 1534272, I think we should go with the patch in that bug for beta.

Comment 8

[Andreea Pavel [:apavel]]

Yes, that's why I asked. Will wait until you guys give the go ahead.
Thank you.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/775f40c959fc
[mozharness] Set repository path in taskcluster; r=aki
https://hg.mozilla.org/integration/autoland/rev/db11228c8a38
[mozharness] Remove explicit setting of branches to use release promotion; r=aki
https://hg.mozilla.org/integration/autoland/rev/3e4b58569126
[mozharness] Don't override PGO settings per-branch; r=aki
https://hg.mozilla.org/integration/autoland/rev/d5c2b9a1c215
[mozharness] Remove support for unused `builds/branch_specifics.py` config; r=aki

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/775f40c959fc
https://hg.mozilla.org/mozilla-central/rev/db11228c8a38
https://hg.mozilla.org/mozilla-central/rev/3e4b58569126
https://hg.mozilla.org/mozilla-central/rev/d5c2b9a1c215

Comment 11

[Tom Prince [:tomprince]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bb986fa5395d
https://hg.mozilla.org/releases/mozilla-beta/rev/3c0a45288132
https://hg.mozilla.org/releases/mozilla-beta/rev/5903d728d99a
https://hg.mozilla.org/releases/mozilla-beta/rev/3a81fd4a729b

Comment 13

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/775f40c959fc0423433733e8894651af3e452d10
Bug 1538134: [mozharness] Set repository path in taskcluster; r=aki

https://hg.mozilla.org/projects/ash/rev/db11228c8a38b5ec3270d0ca224cd49b0204d6c5
Bug 1538134: [mozharness] Remove explicit setting of branches to use release promotion; r=aki

https://hg.mozilla.org/projects/ash/rev/3e4b585691267357d9d664027810fd6488003e2d
Bug 1538134: [mozharness] Don't override PGO settings per-branch; r=aki

https://hg.mozilla.org/projects/ash/rev/d5c2b9a1c21565ea40ff93bbedf431f093aa327c
Bug 1538134: [mozharness] Remove support for unused `builds/branch_specifics.py` config; r=aki