Closed Bug 1538142 Opened 6 years ago Closed 6 years ago

Extra values on events should accept any of the basic types

Categories

(Data Platform and Tools :: Glean: SDK, enhancement, P3)

Product:
Data Platform and Tools
Component:
Glean: SDK
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: mdroettboom, Unassigned)

Details

(Whiteboard: [telemetry:glean-rs:backlog])

As discussed here:

https://github.com/mozilla-mobile/fenix/pull/1067#discussion_r267988597

It's a little cumbersome to do toString() on any values passed into the extra parameter on events. We could support any of the basic scalar types (numbers, string, bools) and convert to strings for the transport inside of glean, rather than putting the onus on the caller.

I wouldn't advocate for allowing different types in the ping transport, as this would complicate the pipeline processing considerably. Nor would I advocate for arbitrary JSON strings with structured data -- we should only support scalars.

Note -- if we do make this change, we should go back through Fenix's use of events to update the API.

Priority: -- → P3
Whiteboard: [telemetry:mobilesdk:m?] → [telemetry:mobilesdk:backlog]
Component: Telemetry → Glean: SDK
Product: Toolkit → Data Platform and Tools
Whiteboard: [telemetry:mobilesdk:backlog] → [telemetry:glean-rs:m?]
Whiteboard: [telemetry:glean-rs:m?] → [telemetry:glean-rs:backlog]
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.