Closed Bug 1538145 Opened 9 months ago Closed 8 months ago

[wpt-sync] Sync PR 15986 - Reland "Async Clipboard Tests: Use quotes as per style guide."

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15986 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15986
Details from upstream follow.

Darwin Huang <huangdarwin@chromium.org> wrote:

Reland "Async Clipboard Tests: Use quotes as per style guide."

This is a reland of db06615901b73ccd41abb8e15954061c61bec3fd

Original change's description:

Async Clipboard Tests: Use quotes as per style guide.

Use ' (single-quotes) for js string quotes, and " (double-quotes) for HTML
string quotes. This was inconsistent before this CL, so make it more
consistent as per the Google JS/HTML style guides.

Reference:

Change-Id: I794b278b2020a329f6e3ea0deeb6136ae04122c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531710
Reviewed-by: Victor Costan \<pwnall@chromium.org>
Commit-Queue: Darwin Huang \<huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642594}

Change-Id: I6c2eec84e4f4a39cebe36fc7b168273ea3b7636e

Reviewed-on: https://chromium-review.googlesource.com/1534778
WPT-Export-Revision: b73932bca807a7addb49c60c387a49f512b5fe1d

PR 15986 applied with additional changes from upstream: 3eb820dcc7cc5255f7182080caf9bd56f04d3cc2, 01e30febfa11d05753eea8bf903b0a6ad084ea9e, 2ff1cef76a4944f5cdb5f5bb3ebbb6c603ed224d, bf545405bfced3e6741af1f661c87c3389f9db24, 6e0def4ccc3f21364bfa6345dec6e42141c0ab89, ed6ced5646ad93fb673606e2699ea0ced1f25f48
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9193699c5d60
[wpt PR 15986] - Reland "Async Clipboard Tests: Use quotes as per style guide.", a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3520943d3a3a
[wpt PR 15986] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c8553bb4a4
[wpt PR 15986] - Reland "Async Clipboard Tests: Use quotes as per style guide.", a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/edcd3a245248
[wpt PR 15986] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.