Closed Bug 1538188 Opened 1 year ago Closed 1 year ago

Avoid displaying garbage in tooltips when there's no previous sample for a tab

Categories

(Toolkit :: Performance Monitoring, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

The work in bug 1483036 pointed out that there's an edge case in about:performance where the values we insert into the tooltips are garbage when there's no previous sample.

I was initially confused by this because we never display the first sample... but if a tab was created between the current sample and the previous one, we have no previous sample for that specific tab.

The rest of the about:performance displays — instead of the value when we have no value to show, so I think the tooltip should just do the same.

Pushed by fqueze@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b4f4d15c0f3
display '—' instead of garbage in the tooltip when there's no previous sample for a tab, r=zbraniecki.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
https://hg.mozilla.org/projects/ash/rev/8b4f4d15c0f3871b3cfc9b5adf57073b2789fd6b
Bug 1538188 - display '—' instead of garbage in the tooltip when there's no previous sample for a tab, r=zbraniecki.
You need to log in before you can comment on or make changes to this bug.