Raptor: Sign fenix and reference-browser builds with the dep key
Categories
(Release Engineering :: Release Automation: Signing, enhancement)
Tracking
(Not tracked)
People
(Reporter: jlorenzo, Assigned: mhentges)
References
Details
Attachments
(2 files)
60 bytes,
text/x-github-pull-request
|
jlorenzo
:
review+
jlorenzo
:
checked-in+
|
Details | Review |
49 bytes,
text/x-github-pull-request
|
jlorenzo
:
review+
jlorenzo
:
checked-in+
|
Details | Review |
In bug 1522225, we want to let Raptor run against the release (as opposed to debug) builds. Raptor installs APKs on real devices which require the APKs to be signed. Sadly, gradle doesn't sign the release APKs by default (only the debug ones).
While we could modify gradle to use the "debug key" to sign these APKs, it's preferable to leverage the "dep" signing key because:
a. the debug key is generated on-the-fly by gradle because we don't store it anywhere. Therefore, we may break the real devices if the same package name changes its signing key, if the previous APK wasn't fully uninstalled.
b. On mozilla-central, the "dep" key is already the one we use if some tests require builds to be signed (for instance XPCShell on Windows). In fact, "dep" stands for "dependencies". In other words, this key is made for dependent jobs.
Reporter | ||
Comment 1•5 years ago
|
||
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 2•5 years ago
|
||
Comment on attachment 9055178 [details] [review] [reference-browser] Dep-sign APKs for Raptor consumption on each master commit Landed on master at https://github.com/mozilla-mobile/reference-browser/commit/5752fef68dafb8218431edc77850a859e1bfb889
Reporter | ||
Comment 3•5 years ago
|
||
Reporter | ||
Comment 4•5 years ago
|
||
Comment on attachment 9056555 [details] [review] [fenix] Dep-sign APKs for Raptor on-master-push mhentges is the author of the patch. r+'d by me at https://github.com/mozilla-mobile/fenix/pull/1417#pullrequestreview-224369136 Landed on master at https://github.com/mozilla-mobile/fenix/commit/6ed0c26dd5b48fbd96ee5fb0e426a1bac63e5def
Reporter | ||
Comment 5•5 years ago
|
||
Both projects are now signed with a different key on every push to master!
Description
•