Closed Bug 1538204 Opened 5 years ago Closed 5 years ago

Raptor: Sign fenix and reference-browser builds with the dep key

Categories

(Release Engineering :: Release Automation: Signing, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: mhentges)

References

Details

Attachments

(2 files)

In bug 1522225, we want to let Raptor run against the release (as opposed to debug) builds. Raptor installs APKs on real devices which require the APKs to be signed. Sadly, gradle doesn't sign the release APKs by default (only the debug ones).

While we could modify gradle to use the "debug key" to sign these APKs, it's preferable to leverage the "dep" signing key because:

a. the debug key is generated on-the-fly by gradle because we don't store it anywhere. Therefore, we may break the real devices if the same package name changes its signing key, if the previous APK wasn't fully uninstalled.
b. On mozilla-central, the "dep" key is already the one we use if some tests require builds to be signed (for instance XPCShell on Windows). In fact, "dep" stands for "dependencies". In other words, this key is made for dependent jobs.

Assignee: jlorenzo → mhentges
Comment on attachment 9055178 [details] [review]
[reference-browser] Dep-sign APKs for Raptor consumption on each master commit

Landed on master at https://github.com/mozilla-mobile/reference-browser/commit/5752fef68dafb8218431edc77850a859e1bfb889
Attachment #9055178 - Flags: review+
Attachment #9055178 - Flags: checked-in+
Comment on attachment 9056555 [details] [review]
[fenix] Dep-sign APKs for Raptor on-master-push

mhentges is the author of the patch.

r+'d by me at https://github.com/mozilla-mobile/fenix/pull/1417#pullrequestreview-224369136

Landed on master at https://github.com/mozilla-mobile/fenix/commit/6ed0c26dd5b48fbd96ee5fb0e426a1bac63e5def
Attachment #9056555 - Flags: review+
Attachment #9056555 - Flags: checked-in+

Both projects are now signed with a different key on every push to master!

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: