1538216 - Perma browser_parsable_css.js | missing chrome://global/skin/media/pictureinpicture.svg referenced from chrome://global/skin/media/videocontrols.css - Gecko 68 merges to Beta on 2019-05-06

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Andreea Pavel [:apavel]]

[Tracking Requested - why for this release]:

Central as Beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=451e269e2e4e5cf53f9caf3ff09b9788e8938861&selectedJob=235470345

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=235470345&repo=try&lineNumber=2740

[task 2019-03-22T13:51:41.949Z] 13:51:41 INFO - TEST-START | browser/base/content/test/static/browser_parsable_css.js
[task 2019-03-22T13:51:43.073Z] 13:51:43 INFO - TEST-INFO | started process screentopng
[task 2019-03-22T13:51:43.569Z] 13:51:43 INFO - TEST-INFO | screentopng: exit 0
[task 2019-03-22T13:51:43.569Z] 13:51:43 INFO - <snipped 28 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test>

[task 2019-03-22T13:51:43.746Z] 13:51:43 INFO - Console message: [JavaScript Warning: "Unknown property ‘user-select’. Declaration dropped." {file: "resource://pdf.js/web/viewer.css?always-parse-css-0.7794747781382897" line: 1558}]
[task 2019-03-22T13:51:43.748Z] 13:51:43 INFO - Buffered messages finished
[task 2019-03-22T13:51:43.749Z] 13:51:43 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | missing chrome://global/skin/media/pictureinpicture.svg referenced from chrome://global/skin/media/videocontrols.css -
[task 2019-03-22T13:51:43.750Z] 13:51:43 INFO - Stack trace:
[task 2019-03-22T13:51:43.752Z] 13:51:43 INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2019-03-22T13:51:43.753Z] 13:51:43 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:422

This appears to be from 1535748, Mike can you take a look?

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Bah, I forgot the ifdef in toolkit/themes/shared/jar.mn. :/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1538216 - Remove NIGHTLY_BUILD ifdef around Picture-in-Picture media assets. r?jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d053fe26d1c
Remove NIGHTLY_BUILD ifdef around Picture-in-Picture media assets. r=jaws

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3d053fe26d1c

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cdbe99f619d3865fc8046b77edd96899999acaa&searchStr=devedition%2Cbrowser-chrome&group_state=expanded