1538253 - VPXDecoder::IsCompatible does not compare subsampling x members correctly

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

VPXDecoder::IsCompatible appears to be using && between mSubSampling_x and aOther.mSubSampling_x where == is likely what was intended.

This will result in cases where either info does not have subsampling in the x dimension to cause the check to indicate they are incompatible, even if they are.

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1538253 - VPXDecoder::IsCompatible checks subsampling x members for equality. r?jya!

We had a stray && where a == should have been.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b0a87b6f940
VPXDecoder::IsCompatible checks subsampling x members for equality. r=jya

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7b0a87b6f940

Comment 4

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9052903 [details]
Bug 1538253 - VPXDecoder::IsCompatible checks subsampling x members for equality. r?jya!

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1482059
• User impact if declined: Negative performance for VP9 videos that don't use subsampling for the x dimension: we will end up recreating decoders far more often than we need to (each key frame).
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None.
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a one line patch that fixes a typo.
• String changes made/needed: None.

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9052903 [details]
Bug 1538253 - VPXDecoder::IsCompatible checks subsampling x members for equality. r?jya!

Typo fix, impacts VP8 performance, uplift approved for 67 beta 6, thanks.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e1be433d0574