1538276 - Implement the "prio" ping for Origin Telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Chris H-C :chutten]

We'll need something (like what EventPing.jsm does for Telemetry Events) that schedules, assembles, and submits the "prio" ping containing Origin Telemetry.

This includes:

• Preferences (and their documentation)
• The implementation
• Tests (xpcshell)
• The async stuff in Telemetry.cpp that I descoped from the skeleton (having the PrioEncoder work happen on a worker thread)

It'll be fun.

Comment 1

[Georg Fritzsche [:gfritzsche]]

The async stuff in Telemetry.cpp that I descoped from the skeleton (having the PrioEncoder work happen on a worker thread)

Is that blocking for a nightly prototype?
Or can that be broken out into a follow-up?

Comment 2

[Chris H-C :chutten]

I've split the "async stuff" off into its own bug (bug 1538815).

Comment 3

[Chris H-C :chutten]

Attachment: Bug 1538276 - Implement the "prio" ping. r?janerik

The "prio" ping contains Origin Telemetry and not much else.

It is enabled only on Firefox Nightly for now.

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1538276 - Test 'prio' ping. r?janerik

Depends on D24781

Comment 5

[Chris H-C :chutten]

Attachment: Data Review Request

Comment 6

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9053614 [details]
Data Review Request

This review is scoped solely to the container, common ping data, and `reason`; individual probes will of course require additional review, which will be more interesting. :)

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/data/prio-ping.html

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :chutten. The collection is supported by tests.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Cat 1.

5) Is the data collection request for default-on or default-off?

Default-on is anticipated.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

No.

9) Does the data collection use a third-party collection tool? **If yes, escalate to legal.**

No.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/635d20864608
Implement the "prio" ping. r=janerik
https://hg.mozilla.org/integration/autoland/rev/5b62c84d2d7b
Test 'prio' ping. r=janerik

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/635d20864608
https://hg.mozilla.org/mozilla-central/rev/5b62c84d2d7b