[TreeView] Make tree view row keyboard navigation consistent with other shared components.
Categories
(DevTools :: Shared Components, enhancement)
Tracking
(firefox68 fixed)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: yzen, Assigned: yzen)
References
Details
(Keywords: access)
Attachments
(1 file)
Right now tree view rows do not really allow for efficient navigation within their focusable elements. Other components such as VirtualizedTree and List components now support "active" state for their tree items and list items respectively.
We'd like to make TreeView work consistently with the other components and to:
- allow to "activate" selected tree rows with keyboard, which
- makes focusable elements within the row tabbable
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
(In reply to Yura Zenevich [:yzen] from comment #1)
Created attachment 9052934 [details]
Bug 1538281 - make tree view row keyboard navigation consistent with other shared components. r=Honza
Just a friendly ping, Jan, let me know if you've got no cycles on this, I can shift the review to someone else.
Thanks.
|
||
Comment 3•5 years ago
|
||
(In reply to Yura Zenevich [:yzen] from comment #2)
Jan, let me know if you've got no cycles on this, I can shift the review to someone else.
Yeah, this would be great. My review queue is long these days.
Honza
|
||
Updated•5 years ago
|
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d124ebd3b9eb make tree view row keyboard navigation consistent with other shared components. r=nchevobbe
|
||
Comment 5•5 years ago
|
||
Backed out changeset d124ebd3b9eb (bug 1538281) for mochitest failures e.g. devtools/client/inspector/extensions/test/browser_inspector_extension_sidebar.js
Backout: https://hg.mozilla.org/integration/autoland/rev/2d7fcd115d9fd9e5cf19b40dcf634d885dc3d2df
Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=02b9a8e35a2a5daa1fa6bdbe1121e4a2694cf031&selectedJob=237807555
Failure log:
browser-chrome: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237807427&repo=autoland&lineNumber=7559
devtools: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237805701&repo=autoland&lineNumber=1781
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/29af6bb009d2 make tree view row keyboard navigation consistent with other shared components. r=nchevobbe
|
||
Comment 7•5 years ago
|
||
Backed out changeset 29af6bb009d2 (bug 1538281) for Devtools failures in devtools/client/jsonview/test/browser_json_refresh.js. CLOSED TREE
Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237889219&repo=autoland&lineNumber=3241
Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=237878918&revision=29af6bb009d2752e1e1ddc5abfe428d19590f373
Backout:
https://hg.mozilla.org/integration/autoland/rev/29af6bb009d2752e1e1ddc5abfe428d19590f373
Backout by dluca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/04228573c1c2 Backed out changeset 29af6bb009d2 for Devtools failures in devtools/client/jsonview/test/browser_json_refresh.js. CLOSED TREE
Pushed by yura.zenevich@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bd190be1c558 make tree view row keyboard navigation consistent with other shared components. r=nchevobbe
|
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 11•5 years ago
|
||
removing ni
|
|
Assignee | |
Updated•5 years ago
|
Description
•