1538285 - "View Saved Logins" text have no contrast with a Dark GTK Theme

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Paulo Eduardo]

Attachment: Light Theme.png

Hi, I'm running Linux Mint and the "View Saved Logins" text have no contrast when using a Dark GTK Theme (eg Arc Dark or Adapta Nokto). The text font colour is white and the background too.

Light Theme Screenshot (also Attached)

Dark Theme Screenshot (also Attached)

As you can see, with the Dark Theme the pane with the credential got the background colour from the GTK Theme, only the footer that render with a white background.

The Firefox Trunk version is 68.0a1 (2019-03-21) (64-bit).

Thank you and sorry if i did something wrong. Should I create a new issue?

Comment 1

[Paulo Eduardo]

Attachment: Dark Theme.png

Comment 2

[Matthew N. [:MattN]]

[Tracking Requested - why for this release]: Accessibility/aesthetic issue in new feature.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1538285 - Make saved logins footer colors theme-friendly. r?MattN

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: dark-mode-saved-logins-footer.png (ubuntu/Adwaita-dark)

Comment 5

[Sam Foster [:sfoster] (he/him)]

OK, I think I have a handle on this now. I've tested Attachment #9053011 [details] in Ubuntu with various light & dark themes, window in normal & dark mode as well as high contrast mode, and OSX.

-moz-fieldText is a system color which will (may) get changed when we change OS theme/mode. The -moz-field background color is on the containing panel. By using a translucent background color (borrowed from --arrowpanel-dimmed and --arrowpanel-dimmed-further) for the footer, we get the same relative contrast as the arrowpanel's footer as well as the selected/highlight effect as the base color is switched by the theme.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4066420a83b
Make saved logins footer colors theme-friendly. r=MattN

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f4066420a83b

Comment 8

[Matthew N. [:MattN]]

Can you confirm this is fixed in the latest Nightly?

Comment 9

[Paulo Eduardo]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #8)

Can you confirm this is fixed in the latest Nightly?

Yes, perfect! Thank you!

Screenshot

Comment 10

[Matthew N. [:MattN]]

Comment on attachment 9053011 [details]
Bug 1538285 - Make saved logins footer colors theme-friendly. r?MattN

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1189618
• User impact if declined: Users on dark OS themes won't have enough contrast on the View Saved Logins autocomplete footer
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1534442
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS-only change using an approach used by another part of the browser UI.
• String changes made/needed: None

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9053011 [details]
Bug 1538285 - Make saved logins footer colors theme-friendly. r?MattN

Uplift approved for 67 beta 7, thanks.

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/732f25bcbf19

Comment 13

[Rares Doghi, Desktop QA]

Hi, I tested this issue in Firefox 67.0b7 and the issue no longer occurs the View Saved Logins text has the proper contrast with different themes applied. I tested this issue on Ubuntu 18.04. I will mark it accordingly.