Closed Bug 1538285 Opened 8 months ago Closed 8 months ago

"View Saved Logins" text have no contrast with a Dark GTK Theme

Categories

(Toolkit :: Password Manager, defect, P1, minor)

All
Linux
defect

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 + verified
firefox68 --- verified

People

(Reporter: pauloeduardo2709, Assigned: sfoster)

References

Details

(Keywords: regression)

Attachments

(4 files)

Attached image Light Theme.png

Hi, I'm running Linux Mint and the "View Saved Logins" text have no contrast when using a Dark GTK Theme (eg Arc Dark or Adapta Nokto). The text font colour is white and the background too.

Light Theme Screenshot (also Attached)

Dark Theme Screenshot (also Attached)

As you can see, with the Dark Theme the pane with the credential got the background colour from the GTK Theme, only the footer that render with a white background.

The Firefox Trunk version is 68.0a1 (2019-03-21) (64-bit).

Thank you and sorry if i did something wrong. Should I create a new issue?

Attached image Dark Theme.png

[Tracking Requested - why for this release]: Accessibility/aesthetic issue in new feature.

Blocks: 1189618
Flags: qe-verify+
Priority: -- → P1
Hardware: x86_64 → All
Attachment #9052928 - Attachment description: Dark Theme.png → Light Theme.png
Assignee: nobody → sfoster
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9052931 - Attachment description: With Dark Theme.png → Dark Theme.png
Attachment #9053011 - Attachment description: Bug 1538285 - Make saved logins footer colors theme-friendly. → Bug 1538285 - WIP/Strawman: Make saved logins footer colors theme-friendly.
Attachment #9053011 - Attachment description: Bug 1538285 - WIP/Strawman: Make saved logins footer colors theme-friendly. → Bug 1538285 - Use the arrowpanel color vars to make saved logins footer colors theme-friendly.
Attachment #9053011 - Attachment description: Bug 1538285 - Use the arrowpanel color vars to make saved logins footer colors theme-friendly. → Bug 1538285 - Make saved logins footer colors theme-friendly.

OK, I think I have a handle on this now. I've tested Attachment #9053011 [details] in Ubuntu with various light & dark themes, window in normal & dark mode as well as high contrast mode, and OSX.

-moz-fieldText is a system color which will (may) get changed when we change OS theme/mode. The -moz-field background color is on the containing panel. By using a translucent background color (borrowed from --arrowpanel-dimmed and --arrowpanel-dimmed-further) for the footer, we get the same relative contrast as the arrowpanel's footer as well as the selected/highlight effect as the base color is switched by the theme.

Attachment #9053011 - Attachment description: Bug 1538285 - Make saved logins footer colors theme-friendly. → Bug 1538285 - Make saved logins footer colors theme-friendly. r?MattN
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4066420a83b
Make saved logins footer colors theme-friendly. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Can you confirm this is fixed in the latest Nightly?

Flags: needinfo?(pauloeduardo2709)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #8)

Can you confirm this is fixed in the latest Nightly?

Yes, perfect! Thank you!

Screenshot

Flags: needinfo?(pauloeduardo2709)

Comment on attachment 9053011 [details]
Bug 1538285 - Make saved logins footer colors theme-friendly. r?MattN

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1189618
  • User impact if declined: Users on dark OS themes won't have enough contrast on the View Saved Logins autocomplete footer
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1534442
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS-only change using an approach used by another part of the browser UI.
  • String changes made/needed: None
Attachment #9053011 - Flags: approval-mozilla-beta?
QA Whiteboard: [qa-triaged]

Comment on attachment 9053011 [details]
Bug 1538285 - Make saved logins footer colors theme-friendly. r?MattN

Uplift approved for 67 beta 7, thanks.

Attachment #9053011 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hi, I tested this issue in Firefox 67.0b7 and the issue no longer occurs the View Saved Logins text has the proper contrast with different themes applied. I tested this issue on Ubuntu 18.04. I will mark it accordingly.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.