Closed Bug 1538293 Opened 10 months ago Closed 10 months ago

Autofill still flickers when typing in all caps

Categories

(Firefox :: Address Bar, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

See bug 1529931 comment 26. It's clearly a problem with autofilling the placeholder, and I'm guessing specifically with the startsWith() check here: https://searchfox.org/mozilla-central/rev/4eaf7c637a303e0f7adcf1ae45064b2d4bef9eb0/browser/components/urlbar/UrlbarInput.jsm#718

If the placeholder is example.com/, and you type E, the placeholder doesn't start with what you typed, but we should autofill the reset of it anyway. (After typing E, Example.com/ does get autofilled when the first result comes in, and then the placeholder is Example.com/. Then when you type X, and the first result comes in, the placeholder becomes EXample.com/, and so on.)

The awesomebar handles this correctly fwiw.

Should audit other startsWith() calls I added in that patch, sigh.

We could test for placeholder autofill by just not waiting for searches to complete before checking the value and selection in the input. i.e., not awaiting UrlbarTestUtils.promiseSearchComplete() et al.

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9efbede2c61c
Make autofilling the placeholder allow changes in case. r=mak
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.