Closed Bug 1538296 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 15938 - Async Clipboard Tests: Use quotes as per style guide.

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15938 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15938
Details from upstream follow.

Darwin Huang <huangdarwin@chromium.org> wrote:

Async Clipboard Tests: Use quotes as per style guide.

Use ' (single-quotes) for js string quotes, and " (double-quotes) for HTML
string quotes. This was inconsistent before this CL, so make it more
consistent as per the Google JS/HTML style guides.

Reference:

Change-Id: I794b278b2020a329f6e3ea0deeb6136ae04122c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531710
Reviewed-by: Victor Costan \<pwnall@chromium.org>
Commit-Queue: Darwin Huang \<huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642594}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 15938 applied with additional changes from upstream: 01e30febfa11d05753eea8bf903b0a6ad084ea9e
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d12bd4375c7 [wpt PR 15938] - Async Clipboard Tests: Use quotes as per style guide., a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/303bac2cade9 [wpt PR 15938] - Async Clipboard Tests: Use quotes as per style guide., a=testonly

https://hg.mozilla.org/mozilla-central/rev/7d12bd4375c7
https://hg.mozilla.org/mozilla-central/rev/303bac2cade9

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.