[wpt-sync] Sync PR 15913 - Turn off Clip Rect caching for elements under sticky positioned elements

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P4
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [wptsync downstream], )

Sync web-platform-tests PR 15913 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15913
Details from upstream follow.

Mason Freed <masonfreed@chromium.org> wrote:

Turn off Clip Rect caching for elements under sticky positioned elements

For elements inside sticky positioned containers that were scrolled, the
cached clip rect did not previously update the scroll position. That
meant that the clip rect did not move with the contents, resulting in
incorrect overlap checks in some cases. To fix this, we have to turn
off caching for elements inside sticky positioned elements, because in
that case the scroll is sometimes included and sometimes not, depending
on whether the sticky constraint is binding.

Bug: 942097, 931853, 935525
Change-Id: Ibd5810c23c8d92b6047709ed06f832acd4770a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526680
Commit-Queue: Chris Harrelson \<chrishtr@chromium.org>
Reviewed-by: Chris Harrelson \<chrishtr@chromium.org>
Auto-Submit: Mason Freed \<masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642524}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ae3a7f98c38
[wpt PR 15913] - Turn off Clip Rect caching for elements under sticky positioned elements, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/24bed144c6e5
[wpt PR 15913] - Turn off Clip Rect caching for elements under sticky positioned elements, a=testonly
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.