Closed Bug 1538306 Opened 9 months ago Closed 9 months ago

Ensure no re-entry when performing an audit for an accessible actor.

Categories

(DevTools :: Accessibility Tools, enhancement)

enhancement
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

Attachments

(2 files)

Right now because the audit call in the Accessible actor is async, it can be called the second time when the first run is not complete. This often happens when we highlight accessible as well as request audit when displaying audit("Checks") section in the a11y panel sidebar. We should:

  • ensure that only 1 audit can run for accessible at any given time
  • there is no style interference from highlighter when the audit is done (primarily an issue for colour contrast only).
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/72b740c734db
ensure that only one audit can run at a given time for an Accessible actor. r=pbro
https://hg.mozilla.org/integration/autoland/rev/76e7655d974e
ensure highlighter bounds overlay does not interfere with the accessible audit. r=pbro
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.