Closed Bug 1538312 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15957 - Revert "Create RTCIceTransport using a webrtc::IceTransportInterface object."

Categories

(Core :: WebRTC, enhancement, P4)

Product:
Core
Component:
WebRTC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15957 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15957
Details from upstream follow.

Alexander Hendrich <hendrich@chromium.org> wrote:

Revert "Create RTCIceTransport using a webrtc::IceTransportInterface object."

This reverts commit dd0f551fcd96d46c6ec2b2a7c543cb2083f1831d.

Reason for revert: causes builders to fail (see bug 944105)

Original change's description:

Create RTCIceTransport using a webrtc::IceTransportInterface object.

Previously, when creating a blink::RTCIceTransport, the corresponding
webrtc::IceTransportInterface object was created by the
IceTransportAdapterImpl. However, in DTLS transport implementation, the
webrtc object is preexisting. Pass the preexisting webrtc object when creating
the blink::RTCIceTransport object in this case.

Bug: 907849
Change-Id: Ia024afc101be830e30f233d6ef1bf39f141227df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520486
Commit-Queue: Marina Ciocea \<marinaciocea@chromium.org>
Reviewed-by: Harald Alvestrand \<hta@chromium.org>
Reviewed-by: Henrik Boström \<hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642487}

TBR=hta@chromium.org,hbos@chromium.org,marinaciocea@chromium.org

Change-Id: I3bddc8e8e6a8ba12bf9a97dd893eb7fc4b4352de
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 907849, 944105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532026
Reviewed-by: Alexander Hendrich \<hendrich@chromium.org>
Commit-Queue: Alexander Hendrich \<hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642555}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → WebRTC
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/679226dc76bf
[wpt PR 15957] - Revert "Create RTCIceTransport using a webrtc::IceTransportInterface object.", a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a9abd169af
[wpt PR 15957] - Revert "Create RTCIceTransport using a webrtc::IceTransportInterface object.", a=testonly

https://hg.mozilla.org/mozilla-central/rev/679226dc76bf
https://hg.mozilla.org/mozilla-central/rev/d8a9abd169af

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.