[wpt-sync] Sync PR 15959 - Make pointerlock on mac lock cursor at display center
Categories
(Core :: DOM: Events, defect, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 15959 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/15959
Details from upstream follow.
Ella Ge <eirage@chromium.org> wrote:
Make pointerlock on mac lock cursor at display center
Before this change, when pointerlock, we "lock" mouse position at where
it is. This causes that we may not receiving mouse events when pointer
is locked outside browser window.This CL doing a few things:
- Move mac setCursorLock to cocoa view (instead of NSViewBridge).
- Make mac pointerlock stores the lock position, move cursor to window
center when entering lock state, and move it back when unlock.- In blink, stores the last_mouse_position_ as the lock position, and
always use the lock position to override event's coordiantes when pointer
is locked.Bug: 542574, 802067
Change-Id: I054ace9342c531c41d6b509879d3c19ba20b4078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516354
Reviewed-by: Avi Drissman \<avi@chromium.org>
Reviewed-by: David Bokan \<bokan@chromium.org>
Reviewed-by: Navid Zolghadr \<nzolghadr@chromium.org>
Reviewed-by: Elly Fong-Jones \<ellyjones@chromium.org>
Commit-Queue: Ella Ge \<eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642681}
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=4239ceea264ad5649e58d1d17c857462578d91ac
Assignee | ||
Comment 2•5 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=693ede5ab8b51d4ba4a593740df9e718569d6fc4
Assignee | ||
Comment 3•5 years ago
|
||
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/45c315454fd0 [wpt PR 15959] - Make pointerlock on mac lock cursor at display center, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/b955e9e7e458 [wpt PR 15959] - Make pointerlock on mac lock cursor at display center, a=testonly
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/45c315454fd0
https://hg.mozilla.org/mozilla-central/rev/b955e9e7e458
Description
•