1538319 - [wpt-sync] Sync PR 15965 - Revert "Async Clipboard Tests: Use quotes as per style guide."

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 15965 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15965
Details from upstream follow.

Carlos Knippschild <[e-mail]> wrote:

Revert "Async Clipboard Tests: Use quotes as per style guide."

This reverts commit db06615901b73ccd41abb8e15954061c61bec3fd.

Reason for revert: broke external/wpt/clipboard-apis/async-interfaces.https.html

Original change's description:

Async Clipboard Tests: Use quotes as per style guide.

Use ' (single-quotes) for js string quotes, and " (double-quotes) for HTML
string quotes. This was inconsistent before this CL, so make it more
consistent as per the Google JS/HTML style guides.

Reference:

• https://google.github.io/styleguide/jsguide.html#features-strings-use-single-quotes
• https://google.github.io/styleguide/htmlcssguide.html#HTML_Quotation_Marks

Change-Id: I794b278b2020a329f6e3ea0deeb6136ae04122c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531710
Reviewed-by: Victor Costan \<[e-mail]>
Commit-Queue: Darwin Huang \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#642594}

TBR=[e-mail],[e-mail]

Change-Id: I85f903d44f39c1b448342183a85d2f9934cecf9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533098
Reviewed-by: Carlos Knippschild \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#642728}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 15965 applied with additional changes from upstream: 01e30febfa11d05753eea8bf903b0a6ad084ea9e, 2ff1cef76a4944f5cdb5f5bb3ebbb6c603ed224d

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3316020bc84639f084ea30325450e1448c6dd18

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c3b67ff595fc08e7516706f3234a6ed5bd4ffd4

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to get results from try push

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd90cc8a39c
[wpt PR 15965] - Revert "Async Clipboard Tests: Use quotes as per style guide.", a=testonly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09c7f6a24bcc
[wpt PR 15965] - Revert "Async Clipboard Tests: Use quotes as per style guide.", a=testonly

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8dd90cc8a39c
https://hg.mozilla.org/mozilla-central/rev/09c7f6a24bcc