[wpt-sync] Sync PR 15966 - Reland "Async Clipboard Tests: Use quotes as per style guide."

RESOLVED FIXED in Firefox 68

Status

()

defect
P4
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [wptsync downstream], )

Sync web-platform-tests PR 15966 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15966
Details from upstream follow.

Darwin Huang <huangdarwin@chromium.org> wrote:

Reland "Async Clipboard Tests: Use quotes as per style guide."

This reverts commit 4b6a562c7bde8700fe66eda5d3f65b3e48750ef2.

patchset 1 contains the original CL, and patchset 2 contains the fix for the issue.

Original change's description:

Revert "Async Clipboard Tests: Use quotes as per style guide."

This reverts commit db06615901b73ccd41abb8e15954061c61bec3fd.

Reason for revert: broke external/wpt/clipboard-apis/async-interfaces.https.html

Original change's description:

Async Clipboard Tests: Use quotes as per style guide.

Use ' (single-quotes) for js string quotes, and " (double-quotes) for HTML
string quotes. This was inconsistent before this CL, so make it more
consistent as per the Google JS/HTML style guides.

Reference:

Change-Id: I794b278b2020a329f6e3ea0deeb6136ae04122c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531710
Reviewed-by: Victor Costan \<pwnall@chromium.org>
Commit-Queue: Darwin Huang \<huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642594}

TBR=pwnall@chromium.org,huangdarwin@chromium.org

Change-Id: I85f903d44f39c1b448342183a85d2f9934cecf9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533098
Reviewed-by: Carlos Knippschild \<carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642728}

TBR=carlosk@chromium.org,pwnall@chromium.org,huangdarwin@chromium.org

Change-Id: Ia50561a9c648e1aa0cd520631b84c3e69a800903
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533207
Commit-Queue: Darwin Huang \<huangdarwin@chromium.org>
Reviewed-by: Victor Costan \<pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642752}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 15966 applied with additional changes from upstream: 01e30febfa11d05753eea8bf903b0a6ad084ea9e, 2ff1cef76a4944f5cdb5f5bb3ebbb6c603ed224d, bf545405bfced3e6741af1f661c87c3389f9db24
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/564fa295d4c2
[wpt PR 15966] - Reland "Async Clipboard Tests: Use quotes as per style guide.", a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33ef5640e038
[wpt PR 15966] - Reland "Async Clipboard Tests: Use quotes as per style guide.", a=testonly
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.