Closed Bug 1538362 Opened 5 months ago Closed 4 months ago

[wpt-sync] Sync PR 15512 - [ChromeDriver] Set key modifiers with mouse actions

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15512 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15512
Details from upstream follow.

Lan Wei <lanwei@chromium.org> wrote:

[ChromeDriver] Set key modifiers with mouse actions

When we have keyboard events and mouse events send together, we should
keep the keys that we are pressing now and set them to the mouse events
that are in the same action sequence.

Bug: chromedriver:1897
Change-Id: I700d7a87d3d0a1b45c1588318ab21314aa284417
Reviewed-on: https://chromium-review.googlesource.com/c/1482009
Reviewed-by: John Chen \<johnchen@chromium.org>
Commit-Queue: Lan Wei \<lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634700}

--

Follow-up commit also included in this PR:

[wpt] Fix actionsWithKeyPressed.html.ini

actionsWithKeyPressed.html test does not work on both Firefox and
Safari, so I change actionsWithKeyPressed.html.ini to skip both
browsers.

Bug: chromedriver:1897
Change-Id: I86fb1507cf86f2fe209414615b8ea73834456202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529624
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642112}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2c21624bc9a
[wpt PR 15512] - [ChromeDriver] Set key modifiers with mouse actions, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4ca06c20ce4
[wpt PR 15512] - [ChromeDriver] Set key modifiers with mouse actions, a=testonly
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.