Closed Bug 1538376 Opened 9 months ago Closed 8 months ago

[wpt-sync] Sync PR 15989 - Revert "[css-flexbox] Try changing min-content contribution for overflow: non-visible"

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15989 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15989
Details from upstream follow.

Christian Biesinger <cbiesinger@chromium.org> wrote:

Revert "[css-flexbox] Try changing min-content contribution for overflow: non-visible"

This reverts commit 3b177346245b4427d3baf03cfdffd8c877ea5f57.

Reason for revert: Not web compatible. Three bugs filed within two weeks of landing. See bug list below. Use counter is pretty high, too.

Original change's description:

[css-flexbox] Try changing min-content contribution for overflow: non-visible

This is an experiment for a spec change the CSSWG is considering:
https://github.com/w3c/csswg-drafts/issues/1865

The plan is to land this shortly after the branch point and see what, if any,
bug reports we get, as it is otherwise difficult to tell if there is any
real-world impact of this change (particular considering that nested
flexboxes would hit this codepath).

We can revert before the stable release if necessary.

Change-Id: I0278653c231be53f3b5123d4915b53c82ee24437
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1377009
Commit-Queue: Christian Biesinger \<cbiesinger@chromium.org>
Reviewed-by: David Grogan \<dgrogan@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Auto-Submit: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#639345}

Bug: 944614, 941975, 943496
TBR=cbiesinger@chromium.org,dgrogan@chromium.org,eae@chromium.org

Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ia0c17f79eda68025613d2ffa65ec3921c81c5f45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534295
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Commit-Queue: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643169}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
PR 15989 applied with additional changes from upstream: dc5ac330e65f29e767d7ce86004be251aad321f6
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e39b649cc22
[wpt PR 15989] - Revert "[css-flexbox] Try changing min-content contribution for overflow: non-visible", a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3254d280b12
[wpt PR 15989] - Revert "[css-flexbox] Try changing min-content contribution for overflow: non-visible", a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.