1538404 - Improve hover state for the Go To Debugger button in the Events overlay

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[:Harald Kirschner :digitarald]

All other icons have a gray-background hover state, while the Go To Debugger icon barely looks like a button.

1. The whole element, that the icon is sitting in, is clickable and has a hand cursor
2. It only has some slight color animation, going from dark gray to black

Options:

1. (more obvious debugger link) Make the filename clickable as well, styled as a link (similar to log locations in the console)
2. (quick fix) Add the dark background hover effect

While we probably want to refactor the Events panel in the coming months; this is a low hanging polish that makes it more usable meanwhile.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

(we should probably do the same for the "select node in inspector" icon in the console)

Comment 2

[:Harald Kirschner :digitarald]

(we should probably do the same for the "select node in inspector" icon in the console)

Might be useful. It does seem more obvious as it has a hand cursor and is not within a block element that is clickable.

Comment 3

[:Harald Kirschner :digitarald]

Attachment: Bug 1538404 - Adding button hover to jump-to-definition on event handlers

The button (using a div) did not have any hover state before this patch.
While the CSS tried to control the stroke color, the SVG was not set up
for this – also fixed in this bug to correctly use the theme colors.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:Harald, could you have a look please?

Comment 5

[:Harald Kirschner :digitarald]

Sorry, was out for PTO and had a merge issue the day before I stepped out. Picking this up again.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc36119ab2b4
Adding button hover to jump-to-definition on event handlers r=nchevobbe

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/cc36119ab2b4