Closed Bug 1538433 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15991 - MSE: Fix mediasource-changetype-play to work with MseBufferByPts

Categories

(Core :: Audio/Video: Playback, enhancement, P4)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15991 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15991
Details from upstream follow.

Matt Wolenetz <wolenetz@chromium.org> wrote:

MSE: Fix mediasource-changetype-play to work with MseBufferByPts

This web-platform-test exercises changeType as it splice-overlaps
pairs of audio or video media streams at varying offsets in the
presentation timeline. Splice-overlapping an out-of-order decode stream
(such as the test AVC MP4 media) at arbitrary times can, per spec, drop
significant decode dependencies from a partially-overlapped GOP such
that a buffered range gap could result.

This change is more careful about where it performs splice-overlaps when
the overlapped media is out-of-order-decode, adjusting the splice point
to be at or very near to the next overlapped keyframe. This prevents
removing out-of-order non-keyframes and their dependents from the
overlapped media such that no buffered range gap nor playback stall
should result.

Note that Chromium is sensitive to such out-of-order buffering overlaps
with the new, compliant, MseBufferByPts behavior.

BUG=807793

Change-Id: I020e244c230756eaa1804f81b58a577124a6a28b

Reviewed-on: https://chromium-review.googlesource.com/1428601
WPT-Export-Revision: 9d802e085916988e7891c81766487f57a93596a6

Component: web-platform-tests → Audio/Video: Playback
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc846bf83bfd
[wpt PR 15991] - MSE: Fix mediasource-changetype-play to work with MseBufferByPts, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c679de39ad4d
[wpt PR 15991] - MSE: Fix mediasource-changetype-play to work with MseBufferByPts, a=testonly

https://hg.mozilla.org/mozilla-central/rev/fc846bf83bfd
https://hg.mozilla.org/mozilla-central/rev/c679de39ad4d

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.