Closed Bug 1538457 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15993 - Barcode Detection Mac: Accept barcode format hint in detector constructor.

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15993 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15993
Details from upstream follow.

Jao-ke Chin-Lee <jchinlee@chromium.org> wrote:

Barcode Detection Mac: Accept barcode format hint in detector constructor.

A user may specify barcode formats to which to restrict detection, which
are converted internally to all known related variants.

For Mac, this is done by setting the "symbologies" property of a Vision
API request. This request created and performs detection in util functions,
and otherwise is handled in wrapped form, so introduce two callbacks:

  • SetupCallback in detection_utils_mac.h, which operates on a request
  • SetupOptionsCallback in barcode_detection_impl_mac_vision.h, which
    becomes a SetupCallback by specifying how a request processes
    BarcodeDetectorOptions.

Change-Id: Ia12d250f9a753187c47c85b0fbc0765840e865ab

Reviewed-on: https://chromium-review.googlesource.com/1530190
WPT-Export-Revision: 40f31844009084ac8b59200650a6e7a1f2a78d85

PR 15993 applied with additional changes from upstream: 7183ea12000b9edaac650b1211c35aa6e0abba88
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d479242a0510
[wpt PR 15993] - Barcode Detection Mac: Accept barcode format hint in detector constructor., a=testonly

https://hg.mozilla.org/mozilla-central/rev/d479242a0510

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.