Closed Bug 1538510 Opened 9 months ago Closed 8 months ago

[wpt-sync] Sync PR 16016 - [css-flex][css-grid] Fix synthesized baseline

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16016 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16016
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:

[css-flex][css-grid] Fix synthesized baseline

When a flex or grid container has no baseline,
its baseline should be synthesized from the border edges.
The same happens for flex and grid items.

Right now we were using the content box in some cases
and even using the margin box in a particular scenario.
The patch fixes this and update the existent tests
to the new behavior. Three new tests are added to WPT too.

At the same time this is also fixing the baseline for
inline flex/grid containers to make it interoperable with Firefox.
Inline blocks have a special behavior per legacy reasons,
which applies to inline flex/grid containers when they have no items;
otherwise the items should be used to compute its baseline.
See more at: https://github.com/w3c/csswg-drafts/issues/3416

BUG=659610,904562
TEST=external/wpt/css/css-align/baseline-rules/synthesized-baseline-flexbox-001.html
TEST=external/wpt/css/css-align/baseline-rules/synthesized-baseline-grid-001.html
TEST=external/wpt/css/css-align/baseline-rules/synthesized-baseline-inline-block-001.html

Change-Id: Ic11fbfc0a6ab9252568ea1734dcbbcbc3dbeb68c
Reviewed-on: https://chromium-review.googlesource.com/1533952
WPT-Export-Revision: 4ce72fd34eae01a2f6edaf75375f2f6567cb2d11

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac6b5da54ad4
[wpt PR 16016] - [css-flex][css-grid] Fix synthesized baseline, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38eaa51de7eb
[wpt PR 16016] - [css-flex][css-grid] Fix synthesized baseline, a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.