Accessibility: Support selection_changed, text_changed and text_selection_changed events for ATK

RESOLVED FIXED

Status

()

RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: yuanyi21, Assigned: yuanyi21)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

17 years ago
These 3 events are very important to ATK.
(Assignee)

Updated

17 years ago
Blocks: 136315
Status: NEW → ASSIGNED
Depends on: 152786
QA Contact: dsirnapalli → jessie.li
(Assignee)

Comment 1

17 years ago
text_selection_changed will be fired from nsCaretAccessible.
Depends on: 153196
(Assignee)

Comment 2

17 years ago
Created attachment 89387 [details] [diff] [review]
modify nsRootAccessible::HandleEvent() according to ATK requests


Added support for EVENT_ATK_SELECTION_CHANGE, EVENT_ATK_TEXT_CARET_MOVE,
EVENT_ATK_TEXT_SELECTION_CHANGE and EVENT_ATK_TEXT_CHANGE.
New event handler was enclosed by #ifdef MOZ_ACCESSIBILITY_ATK/#endif block.
(Assignee)

Updated

17 years ago
Depends on: 151388

Comment 3

17 years ago
I thought there would be bigger differences bettwen the ATK event code and the
MSAA event code in nsRootAccessible::HandleEvent().

Don't you think we should keep as much as possible outside of the #ifdef? That
way we won't have to make changes to those things in two places.

Or do you think it is better to keep them completely separate?
(Assignee)

Comment 4

17 years ago
Checked the code, only the handlers of popupshowing and popuphiding are 
completely same, and I may change them in the near future. The code of 
HandleEvent() is 40%-50% same for two platforms. If separated, there will be 
much same code. Do you agree?

Comment 5

17 years ago
Kyle, I'll let you make the call. ATK has a more complex event system than MSAA.
(Assignee)

Comment 6

17 years ago
I would like to keep the current change. There are much pre-process code.
Seeking r=.

Comment 7

17 years ago
Comment on attachment 89387 [details] [diff] [review]
modify nsRootAccessible::HandleEvent() according to ATK requests

r=aaronl
Attachment #89387 - Flags: review+
(Assignee)

Comment 8

17 years ago
Created attachment 89877 [details] [diff] [review]
some changes of ATK event data struct definitions

changed made:
1) added new event const EVENT_ATK_VISIBLE_DATA_CHANGE for ATK
2) created a new file nsAccessibleEventData.h to hold the event data structs
for ATK. the original place - nsRootAccessible.h - causes MAI module has
redundant compile-dependencies.

Aaron, seeking your r= again.
Attachment #89387 - Attachment is obsolete: true

Updated

17 years ago
Attachment #89877 - Flags: review+

Comment 9

17 years ago
Comment on attachment 89877 [details] [diff] [review]
some changes of ATK event data struct definitions

r=aaronl
Comment on attachment 89877 [details] [diff] [review]
some changes of ATK event data struct definitions

sr=jst
Attachment #89877 - Flags: superreview+
(Assignee)

Comment 11

17 years ago
checked in!
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.