153852 - Accessibility: Support selection_changed, text_changed and text_selection_changed events for ATK

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Kyle Yuan]

These 3 events are very important to ATK.

Comment 1

[Kyle Yuan]

text_selection_changed will be fired from nsCaretAccessible.

Comment 2

[Kyle Yuan]

Attachment: modify nsRootAccessible::HandleEvent() according to ATK requests

Added support for EVENT_ATK_SELECTION_CHANGE, EVENT_ATK_TEXT_CARET_MOVE,
EVENT_ATK_TEXT_SELECTION_CHANGE and EVENT_ATK_TEXT_CHANGE.
New event handler was enclosed by #ifdef MOZ_ACCESSIBILITY_ATK/#endif block.

Comment 3

[Aaron Leventhal]

I thought there would be bigger differences bettwen the ATK event code and the
MSAA event code in nsRootAccessible::HandleEvent().

Don't you think we should keep as much as possible outside of the #ifdef? That
way we won't have to make changes to those things in two places.

Or do you think it is better to keep them completely separate?

Comment 4

[Kyle Yuan]

Checked the code, only the handlers of popupshowing and popuphiding are 
completely same, and I may change them in the near future. The code of 
HandleEvent() is 40%-50% same for two platforms. If separated, there will be 
much same code. Do you agree?

Comment 5

[Aaron Leventhal]

Kyle, I'll let you make the call. ATK has a more complex event system than MSAA.

Comment 6

[Kyle Yuan]

I would like to keep the current change. There are much pre-process code.
Seeking r=.

Comment 7

[Aaron Leventhal]

Comment on attachment 89387 [details] [diff] [review]
modify nsRootAccessible::HandleEvent() according to ATK requests

r=aaronl

Comment 8

[Kyle Yuan]

Attachment: some changes of ATK event data struct definitions

changed made:
1) added new event const EVENT_ATK_VISIBLE_DATA_CHANGE for ATK
2) created a new file nsAccessibleEventData.h to hold the event data structs
for ATK. the original place - nsRootAccessible.h - causes MAI module has
redundant compile-dependencies.

Aaron, seeking your r= again.

Comment 9

[Aaron Leventhal]

Comment on attachment 89877 [details] [diff] [review]
some changes of ATK event data struct definitions

r=aaronl

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 89877 [details] [diff] [review]
some changes of ATK event data struct definitions

sr=jst

Comment 11

[Kyle Yuan]

checked in!