Closed Bug 1538676 Opened 5 years ago Closed 5 years ago

Hide overridden auto-expanded longhand properties when the value is missing

Categories

(DevTools :: Inspector: Rules, defect)

defect
Not set
normal

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: pbro, Assigned: pbro)

References

Details

Attachments

(1 file)

Steps to reproduce:

  • open this URL in a tab: data:text/html,<style>div{--color:red;background:var(--color);background-repeat:no-repeat;}</style><div>inspect me
  • open the inspector
  • select the <div>

The background property is a shorthand. Shorthands usually are preceded by an expander icon to reveal the computed values for longhands. Except here the value contains a CSS variable and as of bug 1535315 we don't reveal longhands in these cases.

Now, in this specific case, one of the longhands is overridden later, and that makes the rule-view still show that one longhand as overridden.
We should probably also hide this, since the value is shown as empty, and we don't currently have a way of getting the actual value.

Depends on: 1535315
Blocks: 1535315
No longer depends on: 1535315
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e724e61a8801
Hide the auto-expanded overridden longhands when value is empty; r=gl
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
https://hg.mozilla.org/projects/ash/rev/e724e61a88017c8301b14f574ddb4c85ce722b65
Bug 1538676 - Hide the auto-expanded overridden longhands when value is empty; r=gl
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: