Export changes - improper focus on Copy All Changes button

NEW
Unassigned

Status

defect
P3
minor
4 months ago
4 months ago

People

(Reporter: cfogel, Unassigned)

Tracking

(Blocks 1 bug)

Trunk
Dependency tree / graph

Firefox Tracking Flags

(firefox67 affected, firefox68 affected)

Details

Attachments

(2 attachments)

Affected versions

  • 67.0b4, 68.0a1 (2019-03-25)

Affected platforms

  • Windows 10; macOS 10.9.5, Ubuntu 18.04

Steps to reproduce

  1. Launch Firefox and open the Changes tab from the devTools inspector;
  2. Make any change in the rules inspector;
  3. Use the keyboard - tab navigate to bring the [Copy All Changes] button in focus;
  4. Press the Enter key.

Expected result

  • step 3: focus lines are on the button's contour;

Actual result

  • There are 2 dotted margins - one for the button and one for the text;

Regression range

Additional notes

  • attached screenshot with the issue;
  • on DarkTheme the focus on the text is colored black, which makes it less noticeable;
  • step 4: on_click effect not applied (even if this isn't an encased button, it might be nice to have some sort of visual effect for it as well).
Has Regression Range: --- → no
Has STR: --- → yes

Same issue can be noticed on the [Copy Rule] button for the hovering on changes.

Priority: -- → P3

I've seen it happen in other tools too. Like the debugger (see screenshot).
We shouldn't block M2 from riding the trains to release based on this bug. But it would be good to fix at some stage.
Might be better to make it block the parent meta bug (bug 1429247) rather than the M2 bug.

Agreed. Moving to lock parent meta bug.

Blocks: track-changes
No longer blocks: 1515875
Has Regression Range: no → ---
You need to log in before you can comment on or make changes to this bug.