1538700 - Warning: Failed prop type: NotificationBox: prop type `wrapping` is invalid

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I am seeing the following warning when opening the Toolbox and selecting the Console panel (or opening the Split Console panel)

Warning: Failed prop type: NotificationBox: prop type `wrapping` is invalid; it must be a function, usually from the `prop-types` package, but received `undefined`.

printWarning resource://devtools/client/shared/vendor/react-dev.js:369
    warning resource://devtools/client/shared/vendor/react-dev.js:393
    checkPropTypes resource://devtools/client/shared/vendor/react-dev.js:1423
    validatePropTypes resource://devtools/client/shared/vendor/react-dev.js:1627
    createElementWithValidation resource://devtools/client/shared/vendor/react-dev.js:1715
    render resource://devtools/client/webconsole/components/App.js:241
    finishClassComponent resource://devtools/client/shared/vendor/react-dom-dev.js:13771
    updateClassComponent resource://devtools/client/shared/vendor/react-dom-dev.js:13733
    beginWork resource://devtools/client/shared/vendor/react-dom-dev.js:14402
    performUnitOfWork resource://devtools/client/shared/vendor/react-dom-dev.js:16441
    workLoop resource://devtools/client/shared/vendor/react-dom-dev.js:16480
    renderRoot resource://devtools/client/shared/vendor/react-dom-dev.js:16520
    performWorkOnRoot resource://devtools/client/shared/vendor/react-dom-dev.js:17138
    performWork resource://devtools/client/shared/vendor/react-dom-dev.js:17060
    performSyncWork resource://devtools/client/shared/vendor/react-dom-dev.js:17032
    requestWork resource://devtools/client/shared/vendor/react-dom-dev.js:16932
    scheduleWork$1 resource://devtools/client/shared/vendor/react-dom-dev.js:16796
    scheduleRootUpdate resource://devtools/client/shared/vendor/react-dom-dev.js:17363
    updateContainerAtExpirationTime resource://devtools/client/shared/vendor/react-dom-dev.js:17390
    updateContainer resource://devtools/client/shared/vendor/react-dom-dev.js:17417
    render resource://devtools/client/shared/vendor/react-dom-dev.js:17700
    legacyRenderSubtreeIntoContainer resource://devtools/client/shared/vendor/react-dom-dev.js:17840
    unbatchedUpdates resource://devtools/client/shared/vendor/react-dom-dev.js:17257
    legacyRenderSubtreeIntoContainer resource://devtools/client/shared/vendor/react-dom-dev.js:17836
    render resource://devtools/client/shared/vendor/react-dom-dev.js:17895
    init resource://devtools/client/webconsole/webconsole-wrapper.js:360
    init resource://devtools/client/webconsole/webconsole-wrapper.js:58
    init resource://devtools/client/webconsole/webconsole-ui.js:66
    init resource://devtools/client/webconsole/webconsole.js:101
    openWebConsole resource://devtools/client/webconsole/hudservice.js:79
    open resource://devtools/client/webconsole/panel.js:59
    onLoad resource://devtools/client/framework/toolbox.js:1863

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

In devtools/client/shared/components/NotificationBox.js#76, we use PropTypes.boolean but it should be PropTypes.bool

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1538700 - Fix NotificationBox proptype. r=Honza.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09dab984c603
Fix NotificationBox proptype. r=Honza.

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/09dab984c603

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I tested this again and the reported problem is properly fixed.
Thanks Nicolas!
Honza

Comment 6

[Alexandru Trif, Desktop QA [:atrif]]

Hello!
Based on comment 5 I'm closing this bug as verified.
Thank you!