Warning: Failed prop type: NotificationBox: prop type `wrapping` is invalid

RESOLVED FIXED in Firefox 68

Status

defect
P2
normal
RESOLVED FIXED
3 months ago
27 days ago

People

(Reporter: Honza, Assigned: nchevobbe)

Tracking

unspecified
Firefox 68
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

I am seeing the following warning when opening the Toolbox and selecting the Console panel (or opening the Split Console panel)

Warning: Failed prop type: NotificationBox: prop type `wrapping` is invalid; it must be a function, usually from the `prop-types` package, but received `undefined`.

printWarning resource://devtools/client/shared/vendor/react-dev.js:369
    warning resource://devtools/client/shared/vendor/react-dev.js:393
    checkPropTypes resource://devtools/client/shared/vendor/react-dev.js:1423
    validatePropTypes resource://devtools/client/shared/vendor/react-dev.js:1627
    createElementWithValidation resource://devtools/client/shared/vendor/react-dev.js:1715
    render resource://devtools/client/webconsole/components/App.js:241
    finishClassComponent resource://devtools/client/shared/vendor/react-dom-dev.js:13771
    updateClassComponent resource://devtools/client/shared/vendor/react-dom-dev.js:13733
    beginWork resource://devtools/client/shared/vendor/react-dom-dev.js:14402
    performUnitOfWork resource://devtools/client/shared/vendor/react-dom-dev.js:16441
    workLoop resource://devtools/client/shared/vendor/react-dom-dev.js:16480
    renderRoot resource://devtools/client/shared/vendor/react-dom-dev.js:16520
    performWorkOnRoot resource://devtools/client/shared/vendor/react-dom-dev.js:17138
    performWork resource://devtools/client/shared/vendor/react-dom-dev.js:17060
    performSyncWork resource://devtools/client/shared/vendor/react-dom-dev.js:17032
    requestWork resource://devtools/client/shared/vendor/react-dom-dev.js:16932
    scheduleWork$1 resource://devtools/client/shared/vendor/react-dom-dev.js:16796
    scheduleRootUpdate resource://devtools/client/shared/vendor/react-dom-dev.js:17363
    updateContainerAtExpirationTime resource://devtools/client/shared/vendor/react-dom-dev.js:17390
    updateContainer resource://devtools/client/shared/vendor/react-dom-dev.js:17417
    render resource://devtools/client/shared/vendor/react-dom-dev.js:17700
    legacyRenderSubtreeIntoContainer resource://devtools/client/shared/vendor/react-dom-dev.js:17840
    unbatchedUpdates resource://devtools/client/shared/vendor/react-dom-dev.js:17257
    legacyRenderSubtreeIntoContainer resource://devtools/client/shared/vendor/react-dom-dev.js:17836
    render resource://devtools/client/shared/vendor/react-dom-dev.js:17895
    init resource://devtools/client/webconsole/webconsole-wrapper.js:360
    init resource://devtools/client/webconsole/webconsole-wrapper.js:58
    init resource://devtools/client/webconsole/webconsole-ui.js:66
    init resource://devtools/client/webconsole/webconsole.js:101
    openWebConsole resource://devtools/client/webconsole/hudservice.js:79
    open resource://devtools/client/webconsole/panel.js:59
    onLoad resource://devtools/client/framework/toolbox.js:1863
Assignee

Updated

3 months ago
Priority: -- → P2
Assignee

Comment 1

3 months ago

In devtools/client/shared/components/NotificationBox.js#76, we use PropTypes.boolean but it should be PropTypes.bool

Assignee

Updated

3 months ago
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED

Comment 3

3 months ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09dab984c603
Fix NotificationBox proptype. r=Honza.

Comment 4

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.