Performance panel breaks remote debugging

VERIFIED FIXED in Firefox 68

Status

defect
P1
normal
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: hani.yacoub, Assigned: jdescottes)

Tracking

(Blocks 1 bug)

68 Branch
Firefox 68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 wontfix, firefox67 wontfix, firefox68 verified)

Details

(Whiteboard: [remote-debugging-reserve])

Attachments

(3 attachments)

[Affected versions]:
Nightly 68.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.14, and Ubuntu 16.04 x64.

[Steps to reproduce]:

  1. Make sure that you are connected to a local Firefox using about:debugging following these instructions:
    https://gist.github.com/juliandescottes/b0d3d83154d9ea8a84db5d32aa35d2c1
    https://www.youtube.com/watch?v=YI0plrxWHf4
  2. Have both profiles "Client Firefox and Server Firefox" running.
  3. From "Tabs" section, click on "Inspect" button for any of the open tabs (ex. reddit.com)
  4. Click on "Performance" panel.
  5. Close this about:devtools-toolbox tab.
  6. Click on "inspect" for that tab again.

[ Expected result]:
A new tab open should open with a valid toolbox.

[Actual result]:
"Connot connect to the debug target." error is displayed. (See screenshot attached)

Priority: -- → P3
No longer blocks: remote-debugging-ng-m2
Priority: P3 → --

The priority flag is not set for this bug.
:jdescottes, could you have a look please?

Flags: needinfo?(jdescottes)

My bad, I wanted to make this block the main meta instead of the m2 meta, but I messed up and simply remove the block field.
This is a leftover from Bug 1524982.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Flags: needinfo?(jdescottes)
Priority: -- → P1

Follow up to 1524982. We started using the browserloader to load almost all perf panel files.
However we kept two async methods in the js file loaded by performance/index.xul, which defeated the purpose.

Depends on D26899
This test would timeout with the fix in the previous patch

Whiteboard: [remote-debugging-reserve]
Blocks: 1532993
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/769d9b3bdd4e
Stop using async methods in performance panel initializer.js;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/ff05581f5fe0
Add test for panel reloading with about:devtools-toolbox;r=daisuke

The failure on browser_perf-range-changed-render.js is a known intermittent that was reopened 13 hours ago before my change landed:
https://bugzilla.mozilla.org/show_bug.cgi?id=1472186

The dt failures on Linux 64 asan already occurred before my push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=6f76423aad074b38071c5415ce68c7e33ba16b7c&selectedJob=239607410
devtools/client/debugger/test/mochitest/browser_dbg-navigation.js | A promise chain failed to handle a rejection: symbols is null

The TV failures are linked to my new tests, but I don't think this should lead to a backout?

Flags: needinfo?(jdescottes)

Julian, bug 1472186 turned perma starting with your push.

Indeed sorry, will investigate

No problem. I was not sure which bug is the cause exactly, that's the reason I backed out both, as they were in the same push.
Thanks for looking into this.

Try is green on Win64 asan for this bug, so the permafail should be linked to the next bug in the queue, Bug 1532993

Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6b726b57f3b
Stop using async methods in performance panel initializer.js;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/13e18860fe36
Add test for panel reloading with about:devtools-toolbox;r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: qe-verify+
Regressions: 1544261

Verified as fixed on Firefox Nightly 68.0a1 (2019-04-17) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 16.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.