1538731 - Performance panel breaks remote debugging

Status: VERIFIED FIXED

(DevTools :: about:debugging, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Attachment: error debug target.png

[Affected versions]:
Nightly 68.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.14, and Ubuntu 16.04 x64.

[Steps to reproduce]:

1. Make sure that you are connected to a local Firefox using about:debugging following these instructions:
   https://gist.github.com/juliandescottes/b0d3d83154d9ea8a84db5d32aa35d2c1
   https://www.youtube.com/watch?v=YI0plrxWHf4
2. Have both profiles "Client Firefox and Server Firefox" running.
3. From "Tabs" section, click on "Inspect" button for any of the open tabs (ex. reddit.com)
4. Click on "Performance" panel.
5. Close this about:devtools-toolbox tab.
6. Click on "inspect" for that tab again.

[ Expected result]:
A new tab open should open with a valid toolbox.

[Actual result]:
"Connot connect to the debug target." error is displayed. (See screenshot attached)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jdescottes, could you have a look please?

Comment 2

[Julian Descottes [:jdescottes]]

My bad, I wanted to make this block the main meta instead of the m2 meta, but I messed up and simply remove the block field.
This is a leftover from Bug 1524982.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1538731 - Stop using async methods in performance panel initializer.js;r=daisuke

Follow up to 1524982. We started using the browserloader to load almost all perf panel files.
However we kept two async methods in the js file loaded by performance/index.xul, which defeated the purpose.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1538731 - Add test for panel reloading with about:devtools-toolbox;r=daisuke

Depends on D26899
This test would timeout with the fix in the previous patch

Comment 5

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ba27b5f1842ceb5ed36565e4a5b9db37ca231a8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/769d9b3bdd4e
Stop using async methods in performance panel initializer.js;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/ff05581f5fe0
Add test for panel reloading with about:devtools-toolbox;r=daisuke

Comment 7

[Andreea Pavel [:apavel]]

Backed out for failing dt at browser_perf-range-changed-render.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=239656526&revision=f7050f15a28dbe22ef9f0f73a9778db0da794fbe

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239656526&repo=autoland&lineNumber=3956

Backout: https://hg.mozilla.org/integration/autoland/rev/54e502f0f78edfe26fc4faa080dcd9ea5f6047a8

Comment 8

[Julian Descottes [:jdescottes]]

The failure on browser_perf-range-changed-render.js is a known intermittent that was reopened 13 hours ago before my change landed:
https://bugzilla.mozilla.org/show_bug.cgi?id=1472186

The dt failures on Linux 64 asan already occurred before my push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=6f76423aad074b38071c5415ce68c7e33ba16b7c&selectedJob=239607410
devtools/client/debugger/test/mochitest/browser_dbg-navigation.js | A promise chain failed to handle a rejection: symbols is null

The TV failures are linked to my new tests, but I don't think this should lead to a backout?

Comment 9

[Andreea Pavel [:apavel]]

Julian, bug 1472186 turned perma starting with your push.

Comment 10

[Julian Descottes [:jdescottes]]

Indeed sorry, will investigate

Comment 11

[Andreea Pavel [:apavel]]

No problem. I was not sure which bug is the cause exactly, that's the reason I backed out both, as they were in the same push.
Thanks for looking into this.

Comment 12

[Julian Descottes [:jdescottes]]

Try is green on Win64 asan for this bug, so the permafail should be linked to the next bug in the queue, Bug 1532993

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6b726b57f3b
Stop using async methods in performance panel initializer.js;r=daisuke
https://hg.mozilla.org/integration/autoland/rev/13e18860fe36
Add test for panel reloading with about:devtools-toolbox;r=daisuke

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c6b726b57f3b
https://hg.mozilla.org/mozilla-central/rev/13e18860fe36

Comment 15

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 68.0a1 (2019-04-17) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 16.04 x64.