1538766 - Enable ESLint rule no-throw-literal in mobile/

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Ian Moody [:Kwan] (UTC+0)]

no-throw-literal helps ensure that when we do throw errors, they come with stack traces that help track down the source of the error.

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1538766 - mobile/ automated ESLint no-throw-literal fixes. r=petru

Result of running:
$ mach eslint -funix mobile/ | sed -Ee 's/:.+//' - | xargs sed -E
-e 's/throw ((["])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["])[^"]+\2 + [^ ";]+);/throw new Error(\1);/g'
-e 's/throw (/throw new Error(/g' -i

Comment 2

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1538766 - mobile/ manual ESLint no-throw-literal fixes. r=petru

Comment 3

[Ian Moody [:Kwan] (UTC+0)]

Thanks petru!

Green try, with one known intermittent (bug 1526729):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e920d55f09cb02ed3cb5ef36f1b8bb27a2498f5

Sheriffs, this is for both this and bug 1538764.
If any later child revisions from other bugs show up in the stack by the time you get to this you don't need to worry about them, only push up to D24732.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2596c01bd847
mobile/ automated ESLint no-throw-literal fixes. r=petru
https://hg.mozilla.org/integration/autoland/rev/1b85204856e2
mobile/ manual ESLint no-throw-literal fixes. r=petru

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/2596c01bd847
https://hg.mozilla.org/mozilla-central/rev/1b85204856e2