Closed Bug 1538771 Opened 5 months ago Closed 5 months ago

QuantumBar gets the match highlighting for trimmed URLs wrong

Categories

(Firefox :: Address Bar, defect, P2)

defect
Points:
2

Tracking

()

VERIFIED FIXED
Firefox 68
Tracking Status
firefox68 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(2 files)

STR:

  1. Visit a url that's http-only.
  2. In QuantumBar, enter a substring of the url.

Expected Results:

  • The substring is correctly highlighted

Actual Results:

  • The substring is off by 7

I'm probably going to fix this as part of bug 1536776, but wanted to record it regardless.

Depends on: 1536776
Blocks: 1538773
Attachment #9053364 - Attachment description: Bug 1538771 - Move trimURL from to BrowserUtils.jsm so it can be more easily accessed in non-window contexts. r?mak,adw → Bug 1538771 - Move trimURL to BrowserUtils.jsm so it can be more easily accessed in non-window contexts. r?mak,adw
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6bd1f37e726c
Move trimURL to BrowserUtils.jsm so it can be more easily accessed in non-window contexts. r=adw
https://hg.mozilla.org/integration/autoland/rev/63ecd27aa7a4
Fix highlighting of matches within URLs in QuantumBar results. r=adw
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Points: --- → 2
QA Contact: cristian.comorasu

I reproduced this issue using Fx 68.0a1(2019-03-24), on Windows 10 x64.
I can confirm this issue is fixed, I verified with Fx 68.0b6, on Windows 10 x64, Ubuntu 16.04 LTS and macOS 10.13.6.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.