TypeError: treeCellInfo.col is null 2 foldersummary.js:210:9

RESOLVED FIXED in Thunderbird 68.0

Status

defect
--
minor
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 68.0

Thunderbird Tracking Flags

(thunderbird67 fixed, thunderbird68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 months ago

When you carefully hover the mouse to the right of the Size column in the folder pane (under the tree column picker widget) and wait a moment so that a tooltip menu coul appear, I get:
TypeError: treeCellInfo.col is null 2 foldersummary.js:210:9

The code is:
let treeCellInfo = gFolderTreeView._tree.getCellAt(event.clientX, event.clientY);
if (treeCellInfo.col.id == "folderNameCol") {

There may not be any column at this place.

Assignee

Updated

3 months ago
Assignee: nobody → acelists
Severity: normal → minor
Assignee

Comment 1

3 months ago
Posted patch 1538789.patchSplinter Review

This should do it. The other change is that if a cell has truncated text (e.g. Size) and the subfolders have zero in that same quantity, we would show nothing. In that case, show that truncated text as the user probably wanted to see it, thus the hover. If subfolders are non-zero we already show the count for the current folder (and also subfolders separately).

Attachment #9053352 - Flags: review?(geoff)
Attachment #9053352 - Flags: review?(geoff) → review+
Assignee

Comment 2

3 months ago

Thanks.

Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 3

3 months ago
Comment on attachment 9053352 [details] [diff] [review]
1538789.patch

This looks like a beta candidate. Can you please consider whether your patches are needed on beta and request uplift.
Attachment #9053352 - Flags: approval-comm-beta+

Comment 4

3 months ago

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3f77eae3ca02
Don't show tooltip if not hovering a cell in the folder pane. Show full cell text when on a truncated cell. r=darktrojan DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

3 months ago
Target Milestone: --- → Thunderbird 68.0
Assignee

Comment 5

3 months ago

I'm not sure when this broke, if it was the conversion to CE, or conversion of trees in m-c. It is not highly critical, if you do not happen to hit that small spot where the is no cell, nothing happens, the other cells work fine. So it would only be a polishing patch landing on beta.

You need to log in before you can comment on or make changes to this bug.