Remote settings record deletion process confusing
Categories
(Cloud Services :: Server: Remote Settings, defect)
Tracking
(Not tracked)
People
(Reporter: englehardt, Assigned: leplatrem)
References
Details
Attachments
(3 files)
UI after deleting a record
Johann and I used remote settings to deploy a new rule for url-classifier-skip-urls as a temporary fix for breakage as described in Bug 1536898. We had some problems during record deletion that we'll document here.
-
When deleting a record, it's not obvious from the UI that deletion requires review. See the attached screenshot as an example, which includes a "Request review" button, but does not give any information as to what the requested review is for. The purpose is only evident after the review is requested, at which point it can be accessed by the "details..." link (second screenshot).
-
On the reviewer side, we experience several errors while trying to review the record deletion. A screenshot of one is attached. I believe Johann had to try multiple times before the deletion was approved. I'll ni Johann for more info.
|
Reporter | |
Comment 1•6 years ago
|
||
|
|
Reporter | |
Comment 2•6 years ago
|
||
|
|
Reporter | |
Comment 3•6 years ago
•
|
||
Johann: Anything to add in regards to the errors you saw during review?
|
Assignee | |
Comment 4•6 years ago
|
||
Thanks for the feedback!
Posted image errors during record deletion review — Details
I don't see any trace of those server errors in our Sentry. When did this happen? Was it with a local server?
We had some issues due to a migration of another service between Mar 21, 2019 10:31:47 PM UTC and Mar 21, 2019 10:33:59 PM UTC. Could have it been during this period?
|
||
Comment 5•6 years ago
|
||
(In reply to Mathieu Leplatre [:leplatrem] from comment #4)
Thanks for the feedback!
Posted image errors during record deletion review — Details
I don't see any trace of those server errors in our Sentry. When did this happen? Was it with a local server?
We had some issues due to a migration of another service between Mar 21, 2019 10:31:47 PM UTC and Mar 21, 2019 10:33:59 PM UTC. Could have it been during this period?
The screenshot was taken on 2019-03-22 at 23.29.16 UTC+1, according to the filename. So one day after the migration, but otherwise matching the time pretty precisely.
On my first try this error message appeared after trying to approve the deletion, and then I think I reloaded the page and it said "no records found", though apparently the record wasn't deleted.
Coming back to it after the weekend pretty much the same thing happened but then apparently the records were deleted successfully. A little strange.
I think we're happy to add some dummy entries if you want to test this out. We're not in release yet, only beta, and inventing some fake domains to test this issue with should be fine.
|
|
Assignee | |
Comment 6•6 years ago
|
||
The screenshot was taken on 2019-03-22 at 23.29.16 UTC+1, according to the filename. So one day after the migration, but otherwise matching the time pretty precisely.
Was it in PROD? Every 500 are reported and I don't see anything beyond errors that happened during that migration.
I think we're happy to add some dummy entries if you want to test this out. We're not in release yet, only beta, and inventing some fake domains to test this issue with should be fine.
Yes, let's try to reproduce on STAGE. I see that you have one record there https://settings.stage.mozaws.net/v1/buckets/main/collections/url-classifier-skip-urls/records
I'm really curious of what could have gone wrong. I'm pretty sure we had several use-cases where deletions were handled successfully (apart from the UX issue obviously).
Thanks!
|
|
Assignee | |
Comment 7•6 years ago
|
||
You can try out the changes we made on UI on STAGE https://settings-writer.stage.mozaws.net/v1/admin/
|
|
Assignee | |
Comment 8•6 years ago
|
||
The new UI should cover what's described in this bug ;)
Description
•