Closed Bug 1539016 Opened 7 months ago Closed 7 months ago

Setting arguments with conditional operator is always considered as not safe

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: masayuki, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

https://searchfox.org/mozilla-central/rev/2c912888e3b7ae4baf161d98d7a01434f31830aa/editor/libeditor/HTMLTableEditor.cpp#99

      CreateElementWithDefaults(aIsHeader ? *nsGkAtoms::th : *nsGkAtoms::td);

If I mark CreateElementWithDefaults() as MOZ_CAN_RUN_SCRIPT, this call is considered as non-safe.

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48e6a07862e0
part 1.  Refactor the MOZ_CAN_RUN_SCRIPT analysis a bit to make new live things easier to add.  r=andi
https://hg.mozilla.org/integration/autoland/rev/4e4f6c867952
part 2.  Teach MOZ_CAN_RUN_SCRIPT analysis about conditional operators.  r=andi
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → bzbarsky
You need to log in before you can comment on or make changes to this bug.