Closed Bug 1539089 Opened 6 months ago Closed 3 months ago

Text on Blacklist button from about:url-classifier is not centered

Categories

(Toolkit :: Safe Browsing, defect, P3, minor)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: cfogel, Assigned: damien.feugas)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

Attached image blackList_button.png

Affected versions

  • 66.0, 67.0b5, 68.0a1(2019-03-26)

Affected platforms

  • Windows 10, macOS 10.14, Ubuntu 16.04;

Steps to reproduce

  1. Launch Firefox and access about:url-classifier
  2. Click on the Blacklist button from the list type section;

Expected result

  • items are centered in the page;

Actual result

  • the Blacklist text from the button is not centered horizontally;

Regression range

  • will provide one asap;

Additional notes

  • attached screenshot with the issue;
  • as a reference, the [Start Searching] button bellow is properly centered;
Has Regression Range: --- → no
Has STR: --- → yes
Component: Layout: Positioned → Safe Browsing
Product: Core → Toolkit
Priority: -- → P2
Priority: P2 → P3
Assignee: nobody → damien.feugas
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7854ee8867a8
Select vertical align in about:url-classifier, r=dao
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Changes verified with 68.0a1 (2019-05-01) on Windows 10, macOS 10.13, Ubuntu 18.04.
While it's not as blatant, the text should still be shifted about 2 pixels down, to be better centered inside the button.

As discussed with :dimi on slack, reopening this issue for it.

Status: RESOLVED → REOPENED
Flags: needinfo?(damien.feugas)
Resolution: FIXED → ---
Assignee: damien.feugas → nobody
Flags: needinfo?(damien.feugas)

I'd like to take up this issue.

Assignee: nobody → robertduda20
Status: REOPENED → ASSIGNED

Hi Robert,
do you still plan to work on this bug?

Flags: needinfo?(robertduda20)

(In reply to Cristian Fogel, QA [:cfogel] from comment #5)

Changes verified with 68.0a1 (2019-05-01) on Windows 10, macOS 10.13, Ubuntu 18.04.
While it's not as blatant, the text should still be shifted about 2 pixels down, to be better centered inside the button.

As discussed with :dimi on slack, reopening this issue for it.

Please file a new bug. I'm closing this again to reflect that the patch fixing the main issue landed in 68.

Assignee: robertduda20 → damien.feugas
Status: ASSIGNED → RESOLVED
Closed: 5 months ago3 months ago
Flags: needinfo?(robertduda20)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.