Closed Bug 1539115 Opened 11 months ago Closed 8 months ago

Metric files need to have license notice at their top

Categories

(Toolkit :: Telemetry, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: Dexter, Assigned: hgallagher, Mentored)

References

Details

(Whiteboard: [good first bug][lang=txt])

Attachments

(1 file)

(In reply to Georg Fritzsche [:gfritzsche] from bug 1538139 comment #3)

To my knowledge, all code, configuration files, etc. in Firefox and other Mozilla code bases must have our license.
There are only explicit exceptions, like for test files.

As a component owner i say: Let's just put the applicable licenses on it.

See Also: → 1538139

Jan-Erik, would you be interested in setting this up for mentoring?

Flags: needinfo?(jrediger)

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
  3. Start working on this bug.
    • Add the below license comment to the files toolkit/components/telemetry/Scalars.yaml, toolkit/components/telemetry/Processes.yaml and toolkit/components/telemetry/Events.yaml. Make sure you have an empty line after the license block and before the actual content.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC (https://wiki.mozilla.org/Irc) most hours of most days.
  4. Build your change with mach build to test that these are still valid yaml files (if you don't have a full build set up, don't worry, I can catch if anything is wrong in the review)
  5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

License block:

# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
Mentor: jrediger
Flags: needinfo?(jrediger)
Whiteboard: [good next bug][lang=txt]
Whiteboard: [good next bug][lang=txt] → [good first bug][lang=txt]

One thing to note (probably need discussion in a followup): We also have Histograms.json, but JSON doesn't have comments. We could use a hack ({"//comment": "This Source Code ..."}) but ... ugh.

Priority: -- → P3

Hi, I just found this bug and I'll be able to do it either today or tomorrow if anyone wants to assign me 🙂

Assignee: nobody → hgallagher
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2b0e95967fd
Add license to telemetry yaml files. r=janerik
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.