Metric files need to have license notice at their top
Categories
(Toolkit :: Telemetry, enhancement, P3)
Tracking
()
People
(Reporter: Dexter, Assigned: hgallagher, Mentored)
References
Details
(Whiteboard: [good first bug][lang=txt])
Attachments
(1 file)
(In reply to Georg Fritzsche [:gfritzsche] from bug 1538139 comment #3)
To my knowledge, all code, configuration files, etc. in Firefox and other Mozilla code bases must have our license.
There are only explicit exceptions, like for test files.As a component owner i say: Let's just put the applicable licenses on it.
Comment 1•5 years ago
|
||
Jan-Erik, would you be interested in setting this up for mentoring?
Comment 2•5 years ago
|
||
To help Mozilla out with this bug, here's the steps:
- Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
- Download and build the Firefox source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
- If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
- You can also read the Developer Guide, which has answers to most development questions: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
- Start working on this bug.
- Add the below license comment to the files
toolkit/components/telemetry/Scalars.yaml
,toolkit/components/telemetry/Processes.yaml
andtoolkit/components/telemetry/Events.yaml
. Make sure you have an empty line after the license block and before the actual content. - If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC (https://wiki.mozilla.org/Irc) most hours of most days.
- Add the below license comment to the files
- Build your change with
mach build
to test that these are still valid yaml files (if you don't have a full build set up, don't worry, I can catch if anything is wrong in the review) - Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
- After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
- ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
License block:
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
Updated•5 years ago
|
Comment 3•5 years ago
|
||
One thing to note (probably need discussion in a followup): We also have Histograms.json
, but JSON doesn't have comments. We could use a hack ({"//comment": "This Source Code ..."}
) but ... ugh.
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Hi, I just found this bug and I'll be able to do it either today or tomorrow if anyone wants to assign me 🙂
Assignee | ||
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f2b0e95967fd Add license to telemetry yaml files. r=janerik
Comment 7•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•