1539137 - Language settings Help doc link points to Webpage language settings Help doc

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Ton [:Tonnes]]

In FF 66, it looks like the Help button for the new Language settings dialog points to the same doc as the Webpage language settings Help button does, both resulting in https://support.mozilla.org/en-US/kb/choose-display-languages-multilingual-web-pages.

The problem may be here: https://searchfox.org/mozilla-central/source/browser/components/preferences/browserLanguages.xul#20

See bug 1485779 for the proper link.

Comment 1

[Francesco Lodolo [:flod]]

https://support.mozilla.org/en-US/kb/use-firefox-another-language

It take that value should be 'use-firefox-another-language' (I haven't tried), and it might be a good-first-bug.

Comment 2

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Bad UI that should be easy to fix in time for 67.

This has been broken since the original implementation in bug 1469688.

(In reply to Francesco Lodolo [:flod] from comment #1)

https://support.mozilla.org/en-US/kb/use-firefox-another-language

It take that value should be 'use-firefox-another-language' (I haven't tried), and it might be a good-first-bug.

This doesn't work, we need a public redirect URL for this page that we can plug into the language-specific SUMO URLs we generate from app.support.baseURL (ie https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/ + "suffix" ) which normally entails asking someone from SUMO.

Mark, is there an existing redirect slug in place for the use-firefox-another-language page that you're aware of? If not, we should ping Joni.

Comment 3

[Mark Striemer [:mstriemer]]

Joni, can you generate a slug for the https://support.mozilla.org/en-US/kb/use-firefox-another-language page or let me know what was already generated? I don't see one in bug 1485779 where we were tracking this SUMO page.

Looks like we were going to use the same page for both, but they're on different pages. Once we have the slug we can link to this one directly.

Comment 4

[Joni Chan]

Sure, Mark. There wasn't an in-product slug yet so here's a new slug you can use: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/change-language

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1539137 - Fix help link in browser languages dialog r?Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25f585dc1f7f
Fix help link in browser languages dialog r=Gijs

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/25f585dc1f7f

Comment 8

[Francesco Lodolo [:flod]]

Verified on 68.0a1 (2019-04-04) (64 bit)

Comment 9

[Francesco Lodolo [:flod]]

Comment on attachment 9055595 [details]
Bug 1539137 - Fix help link in browser languages dialog r?Gijs

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: None
• User impact if declined: Link to SUMO for the language-switcher feature points to the wrong documentation
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just correcting an existing link
• String changes made/needed: none

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9055595 [details]
Bug 1539137 - Fix help link in browser languages dialog r?Gijs

Trivial fix for a SUMO link, verified on Nightly, uplift approved for 67 beta 9, thanks.

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3ba898f98afa