Refactor WindowGlobalParent/WindowGlobalChild

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P2
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: jdai, Assigned: jdai)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Fission Milestone:M2, firefox68 fixed)

Details

(Whiteboard: [5/3] patch bounced, looking into it)

Attachments

(2 attachments)

Assignee

Description

3 months ago

It's starting to seem like it'd be nice to have a common base class for WindowGlobalChild and WindowGlobalParent...

Maybe we can do that in a follow-up to simplify this code & allow us to just use virtual methods.

Updated

2 months ago
Fission Milestone: --- → M2

Updated

2 months ago
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee

Updated

2 months ago
Summary: Refactor JSWindowActorService → Refactor WindowGlobalParent/WindowGlobalChild

Updated

2 months ago
Whiteboard: [5/1] patches under review

Comment 3

2 months ago
Pushed by jdai@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fa4ae41da87
Part 1: Remove unused function; r=nika
https://hg.mozilla.org/integration/autoland/rev/366f29cc8ce7
Part 2: Refactor WindowGlobalParent and WindowGlobalChild; r=nika

Updated

2 months ago
Whiteboard: [5/1] patches under review → [5/3] patch bounced, looking into it
Assignee

Comment 5

2 months ago
Flags: needinfo?(jdai)

Comment 6

2 months ago
Pushed by jdai@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/349bb2c0cfac
Part 1: Remove unused function; r=nika
https://hg.mozilla.org/integration/autoland/rev/24bc67a8d261
Part 2: Refactor WindowGlobalParent and WindowGlobalChild; r=nika

Comment 7

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.