Closed Bug 1539147 Opened 1 year ago Closed 1 year ago

Refactor WindowGlobalParent/WindowGlobalChild

Categories

(Core :: IPC, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Fission Milestone M2
Tracking Status
firefox68 --- fixed

People

(Reporter: jdai, Assigned: jdai)

References

Details

(Whiteboard: [5/3] patch bounced, looking into it)

Attachments

(2 files)

It's starting to seem like it'd be nice to have a common base class for WindowGlobalChild and WindowGlobalParent...

Maybe we can do that in a follow-up to simplify this code & allow us to just use virtual methods.

Fission Milestone: --- → M2
Status: NEW → ASSIGNED
Priority: -- → P2
Summary: Refactor JSWindowActorService → Refactor WindowGlobalParent/WindowGlobalChild
Whiteboard: [5/1] patches under review
Pushed by jdai@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fa4ae41da87
Part 1: Remove unused function; r=nika
https://hg.mozilla.org/integration/autoland/rev/366f29cc8ce7
Part 2: Refactor WindowGlobalParent and WindowGlobalChild; r=nika
Whiteboard: [5/1] patches under review → [5/3] patch bounced, looking into it
Flags: needinfo?(jdai)
Pushed by jdai@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/349bb2c0cfac
Part 1: Remove unused function; r=nika
https://hg.mozilla.org/integration/autoland/rev/24bc67a8d261
Part 2: Refactor WindowGlobalParent and WindowGlobalChild; r=nika
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.