1539147 - Refactor WindowGlobalParent/WindowGlobalChild

Status: RESOLVED FIXED

(Core :: IPC, enhancement, P2)

Description

[John Dai[:jdai]]

It's starting to seem like it'd be nice to have a common base class for WindowGlobalChild and WindowGlobalParent...

Maybe we can do that in a follow-up to simplify this code & allow us to just use virtual methods.

Comment 1

[John Dai[:jdai]]

Attachment: Bug 1539147 - Part 1: Remove unused function;

Comment 2

[John Dai[:jdai]]

Attachment: Bug 1539147 - Part 2: Refactor WindowGlobalParent and WindowGlobalChild;

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fa4ae41da87
Part 1: Remove unused function; r=nika
https://hg.mozilla.org/integration/autoland/rev/366f29cc8ce7
Part 2: Refactor WindowGlobalParent and WindowGlobalChild; r=nika

Comment 4

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1539147) for Build bustage in builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/WindowGlobalActor.h. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=244511076&repo=autoland&lineNumber=14692

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=244506285&revision=366f29cc8ce7caedd57c830b8febd02aac3edd1d

Backout:
https://hg.mozilla.org/integration/autoland/rev/1acfb43661fdfef09a5b9dde0df90a5f849a111c

Comment 5

[John Dai[:jdai]]

(In reply to Dorel Luca [:dluca] from comment #4)

Backed out 2 changesets (bug 1539147) for Build bustage in builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/dom/WindowGlobalActor.h. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=244511076&repo=autoland&lineNumber=14692

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=244506285&revision=366f29cc8ce7caedd57c830b8febd02aac3edd1d

Backout:
https://hg.mozilla.org/integration/autoland/rev/1acfb43661fdfef09a5b9dde0df90a5f849a111c

I'm working on it. Sorry for any inconvenience.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1814fc48a732fd54b9c767b94af5e8773867442f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/349bb2c0cfac
Part 1: Remove unused function; r=nika
https://hg.mozilla.org/integration/autoland/rev/24bc67a8d261
Part 2: Refactor WindowGlobalParent and WindowGlobalChild; r=nika

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/349bb2c0cfac
https://hg.mozilla.org/mozilla-central/rev/24bc67a8d261