1539166 - Use shared ping scheduler logic in TelemetryController

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Georg Fritzsche [:gfritzsche]]

We now introduced a ~daily schedule logic for main pings, ecosystem pings & prio pings.

Can we move TelemetrySessions scheduler to TelemetryController and use it to drive all 3 pings?
That would give us shared scheduling logic.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Jan-Erik, would this fit into this iteration on your end?
I think it would be good to get this out of the way to enable a good start into Q2.

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1539166 - Refactor the session scheduler into its own module

This is in preparation for further logic refactoring in later commits.

Comment 3

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1539166 - Remove expired probes from scheduler

Depends on D26147

Comment 4

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1539166 - Remove unused variables

Depends on D26148

Comment 5

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1539166 - Simplify daily ping reschedule

This is only called on environment-changed pings.
We avoid re-setting the scheduler timeout, so that we can trigger other
pings at regular intervals unrelated to main pings.
This will not cause the daily ping to be sent more often, at worst we
schedule something once too frequently.

Depends on D26149

Comment 6

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1539166 - Allow other periodic pings to be sent at regular intervals

Depends on D26150

Comment 7

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1539166 - Trigger periodic ecosystem ping once a day

Depends on D26151

Comment 8

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1539166 - Trigger periodic prio ping once a day

Depends on D26152

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c0325bf2543
Refactor the session scheduler into its own module r=chutten
https://hg.mozilla.org/integration/autoland/rev/e66a133f9624
Remove expired probes from scheduler r=chutten
https://hg.mozilla.org/integration/autoland/rev/19caa11e5eb7
Remove unused variables r=chutten
https://hg.mozilla.org/integration/autoland/rev/50ada71796e4
Simplify daily ping reschedule r=chutten
https://hg.mozilla.org/integration/autoland/rev/5bac63a7f021
Allow other periodic pings to be sent at regular intervals r=chutten
https://hg.mozilla.org/integration/autoland/rev/42c3f90105c1
Trigger periodic ecosystem ping once a day r=chutten
https://hg.mozilla.org/integration/autoland/rev/16819d232d4d
Trigger periodic prio ping once a day r=chutten

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2c0325bf2543
https://hg.mozilla.org/mozilla-central/rev/e66a133f9624
https://hg.mozilla.org/mozilla-central/rev/19caa11e5eb7
https://hg.mozilla.org/mozilla-central/rev/50ada71796e4
https://hg.mozilla.org/mozilla-central/rev/5bac63a7f021
https://hg.mozilla.org/mozilla-central/rev/42c3f90105c1
https://hg.mozilla.org/mozilla-central/rev/16819d232d4d