Closed Bug 1539204 Opened 7 months ago Closed 7 months ago

Wrap MOZ_KnownLive around subjectPrincipal args

Categories

(Core :: DOM: Bindings (WebIDL), enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.

This is legwork for adding MOZ_KNOWN_LIVE, because it puts the conversion to
nsIPrincipal& inside the future MOZ_KnownLive. Most of the changes are just
moving code around a bit and switching prepend() calls for append() calls as a
result.

I have verified that the only change in the generated code is the
addition of NonNullHelper() calls. A diff of the generated code is available
at https://phabricator.services.mozilla.com/F1241622.

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a318c91c2cf0
part 1.  Wrap NonNullHelper() around subject principal args when the stack value is NonNull.  r=qdot
https://hg.mozilla.org/integration/autoland/rev/d0fcce1c325d
part 2.  Mark subject principal args in bindings as known-live.  r=qdot
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → bzbarsky
You need to log in before you can comment on or make changes to this bug.